Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose tokenCount on the DocumentNode #4292

Merged
merged 1 commit into from
Nov 8, 2024
Merged

Conversation

JoviDeCroock
Copy link
Member

@JoviDeCroock JoviDeCroock commented Nov 8, 2024

Backports #4251 from v17

Backporting this so we can document the maxTokens for production use cases. The performance of this change looks to be neutral

@JoviDeCroock JoviDeCroock requested a review from a team as a code owner November 8, 2024 08:55
Copy link

github-actions bot commented Nov 8, 2024

Hi @JoviDeCroock, I'm @github-actions bot happy to help you with this PR 👋

Supported commands

Please post this commands in separate comments and only one per comment:

  • @github-actions run-benchmark - Run benchmark comparing base and merge commits for this PR
  • @github-actions publish-pr-on-npm - Build package from this PR and publish it on NPM

@JoviDeCroock

This comment has been minimized.

Copy link

github-actions bot commented Nov 8, 2024

@github-actions run-benchmark

@JoviDeCroock

Benchmark output

graphql@16.9.0 benchmark
node benchmark/benchmark.js "--revs" "HEAD" "BASE"

🍳 Preparing HEAD...
🍳 Preparing BASE...
⏱ Build Schema from AST
�[36m1�[0m tests completed.
�[36m2�[0m tests completed.

�[32mHEAD�[0m�[90m x �[0m�[32m42.36�[0m ops/sec �[90m±�[0m�[32m0.83�[0m�[36m%�[0m�[90m x �[0m 2.2 MB/op�[90m (8 runs sampled)�[0m
BASE�[90m x �[0m�[32m42.21�[0m ops/sec �[90m±�[0m�[32m0.54�[0m�[36m%�[0m�[90m x �[0m2.18 MB/op�[90m (8 runs sampled)�[0m

⏱ Build Schema from Introspection
�[36m1�[0m tests completed.
�[36m2�[0m tests completed.

�[32mHEAD�[0m�[90m x �[0m�[32m51.03�[0m ops/sec �[90m±�[0m�[32m0.83�[0m�[36m%�[0m�[90m x �[0m1.12 MB/op�[90m (11 runs sampled)�[0m
BASE�[90m x �[0m�[32m51.01�[0m ops/sec �[90m±�[0m�[33m2.35�[0m�[36m%�[0m�[90m x �[0m1.12 MB/op�[90m (11 runs sampled)�[0m

⏱ Execute Introspection Query
�[36m1�[0m tests completed.
�[36m2�[0m tests completed.

HEAD�[90m x �[0m�[32m 48.8�[0m ops/sec �[90m±�[0m�[32m1.32�[0m�[36m%�[0m�[90m x �[0m2.49 MB/op�[90m (8 runs sampled)�[0m
�[32mBASE�[0m�[90m x �[0m�[32m49.89�[0m ops/sec �[90m±�[0m�[32m1.04�[0m�[36m%�[0m�[90m x �[0m2.49 MB/op�[90m (8 runs sampled)�[0m

⏱ Parse introspection query
�[36m1�[0m tests completed.
�[36m2�[0m tests completed.

HEAD�[90m x �[0m�[32m13,524�[0m ops/sec �[90m±�[0m�[32m0.35�[0m�[36m%�[0m�[90m x �[0m2.62 KB/op�[90m (34 runs sampled)�[0m
�[32mBASE�[0m�[90m x �[0m�[32m13,978�[0m ops/sec �[90m±�[0m�[32m0.43�[0m�[36m%�[0m�[90m x �[0m1.95 KB/op�[90m (35 runs sampled)�[0m

⏱ Many repeated fields
�[36m1�[0m tests completed.
�[36m2�[0m tests completed.

HEAD�[90m x �[0m�[32m97.93�[0m ops/sec �[90m±�[0m�[32m0.68�[0m�[36m%�[0m�[90m x �[0m524 KB/op�[90m (20 runs sampled)�[0m
�[32mBASE�[0m�[90m x �[0m�[32m98.34�[0m ops/sec �[90m±�[0m�[32m0.48�[0m�[36m%�[0m�[90m x �[0m523 KB/op�[90m (20 runs sampled)�[0m

⏱ Validate Introspection Query
�[36m1�[0m tests completed.
�[36m2�[0m tests completed.

�[32mHEAD�[0m�[90m x �[0m�[32m559�[0m ops/sec �[90m±�[0m�[32m0.42�[0m�[36m%�[0m�[90m x �[0m270 KB/op�[90m (14 runs sampled)�[0m
BASE�[90m x �[0m�[32m555�[0m ops/sec �[90m±�[0m�[32m0.53�[0m�[36m%�[0m�[90m x �[0m269 KB/op�[90m (14 runs sampled)�[0m

⏱ Validate Invalid Query
�[36m1�[0m tests completed.
�[36m2�[0m tests completed.

�[32mHEAD�[0m�[90m x �[0m�[32m503�[0m ops/sec �[90m±�[0m�[32m0.47�[0m�[36m%�[0m�[90m x �[0m326 KB/op�[90m (14 runs sampled)�[0m
BASE�[90m x �[0m�[32m502�[0m ops/sec �[90m±�[0m�[32m0.31�[0m�[36m%�[0m�[90m x �[0m327 KB/op�[90m (14 runs sampled)�[0m

⏱ Validate SDL Document
�[36m1�[0m tests completed.
�[36m2�[0m tests completed.

HEAD�[90m x �[0m�[32m62.79�[0m ops/sec �[90m±�[0m�[32m1.63�[0m�[36m%�[0m�[90m x �[0m223 KB/op�[90m (10 runs sampled)�[0m
�[32mBASE�[0m�[90m x �[0m�[32m63.32�[0m ops/sec �[90m±�[0m�[32m1.14�[0m�[36m%�[0m�[90m x �[0m223 KB/op�[90m (10 runs sampled)�[0m

⏱ Visit all AST nodes
�[36m1�[0m tests completed.
�[36m2�[0m tests completed.

HEAD�[90m x �[0m�[32m299�[0m ops/sec �[90m±�[0m�[33m2.48�[0m�[36m%�[0m�[90m x �[0m311 KB/op�[90m (19 runs sampled)�[0m
�[32mBASE�[0m�[90m x �[0m�[32m302�[0m ops/sec �[90m±�[0m�[32m1.53�[0m�[36m%�[0m�[90m x �[0m311 KB/op�[90m (19 runs sampled)�[0m

⏱ Visit all AST nodes in parallel
�[36m1�[0m tests completed.
�[36m2�[0m tests completed.

HEAD�[90m x �[0m�[32m28.19�[0m ops/sec �[90m±�[0m�[32m0.28�[0m�[36m%�[0m�[90m x �[0m1.23 MB/op�[90m (7 runs sampled)�[0m
�[32mBASE�[0m�[90m x �[0m�[32m 28.3�[0m ops/sec �[90m±�[0m�[32m0.25�[0m�[36m%�[0m�[90m x �[0m1.23 MB/op�[90m (7 runs sampled)�[0m

@JoviDeCroock JoviDeCroock added the PR: feature 🚀 requires increase of "minor" version number label Nov 8, 2024
@JoviDeCroock JoviDeCroock merged commit 10cc0ac into 16.x.x Nov 8, 2024
31 checks passed
@JoviDeCroock JoviDeCroock deleted the backport-token-count branch November 8, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: feature 🚀 requires increase of "minor" version number
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants