Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace styled-jsx with styled-components #200

Closed
schickling opened this issue Oct 30, 2017 · 4 comments
Closed

Replace styled-jsx with styled-components #200

schickling opened this issue Oct 30, 2017 · 4 comments

Comments

@schickling
Copy link
Collaborator

styled-jsx introduces a lot of build-time complexity. Would be great if it could be replaced with styled-components.

@steida
Copy link

steida commented Oct 30, 2017

Just curious which complexity? styled-components are by my observation much leaky abstraction.

@schickling
Copy link
Collaborator Author

The current build-setup is very complicated and involves multiple forked packages (and is currently hard to get locally set up). To make it easier for new developers to contribute to graphql-playground the build setup should be a simple as possible.

@morajabi
Copy link
Collaborator

morajabi commented Oct 30, 2017

@schickling I'd like to do this! Since I have a fair amount of experience with styled-components and I'm part of the team too.

@schickling
Copy link
Collaborator Author

This will involve a fair amount of work @morajabi but this would be absolutely great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants