Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove of old styling #834

Merged
merged 23 commits into from
Oct 15, 2018
Merged

Remove of old styling #834

merged 23 commits into from
Oct 15, 2018

Conversation

huv1k
Copy link
Collaborator

@huv1k huv1k commented Sep 10, 2018

This PR removed all old styling the only source of truth is styled-components right now. Closes #200

Size of package before removing old styling:

File sizes after gzip:

  658.87 KB  build/static/js/index.js
  642.04 KB  build/static/js/middleware.js
  352 B      build/static/css/middleware.css
  348 B      build/static/css/index.css

After removing old styles:

File sizes after gzip:

  582.74 KB  build/static/js/index.js
  569.56 KB  build/static/js/middleware.js
  352 B      build/static/css/middleware.css
  348 B      build/static/css/index.css

@huv1k huv1k changed the title WIP - Rewrite of styles Remove of old styling Sep 23, 2018
@morajabi
Copy link
Collaborator

@HuVik Thanks a lot for finishing my half-written effort 🙈😅Sorry about leaving it like that. You're awesome :D

@huv1k huv1k merged commit d3a7119 into master Oct 15, 2018
@huv1k huv1k deleted the styled-finish branch November 13, 2018 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants