Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide close icon for inactive tabs #289

Closed
schickling opened this issue Dec 1, 2017 · 1 comment
Closed

Hide close icon for inactive tabs #289

schickling opened this issue Dec 1, 2017 · 1 comment
Assignees
@morajabi
Labels
status/pr-welcome

Comments

@schickling
Copy link
Collaborator

Currently, the close icon is visible for all tabs. The close icon should just be visible for the currently selected and/or hovered tab. (See the implementation of VSCode.)
@kbrandwijk
Copy link
Contributor

For illustration purposes:
hideclose

@morajabi morajabi self-assigned this Dec 3, 2017
morajabi added a commit that referenced this issue Dec 3, 2017
@morajabi
feat: hide close button for inactive tabs (Fixes #289)
c0059e5
@morajabi morajabi mentioned this issue Dec 3, 2017
Merged
DeltaEvo pushed a commit to Popcorn-moe/graphql-playground that referenced this issue Dec 16, 2017
@morajabi
feat: hide close button for inactive tabs (Fixes graphql#289)
897e62b
cgxxv pushed a commit to cgxxv/graphql-playground that referenced this issue Mar 25, 2022
@morajabi
feat: hide close button for inactive tabs (Fixes graphql#289)
a1fb094
@dbrambilla dbrambilla mentioned this issue Nov 27, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@morajabi morajabi

Labels
status/pr-welcome
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kbrandwijk @schickling @morajabi