Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix windows keyboard shortcuts #514

Merged
merged 1 commit into from
May 28, 2018

Conversation

fabien0102
Copy link
Contributor

@fabien0102 fabien0102 commented Jan 19, 2018

We don't have Cmd available on windows 😉

Fixes #513 .

Changes proposed in this pull request:

  • Use CmdOrCtrl instead of Cmd to support windows shortcuts syntax

Note: I can't test on my computer due to some issue with the webpack configuration…

Ref: https://github.com/electron/electron/blob/master/docs/tutorial/keyboard-shortcuts.md

We don't have `Cmd` available on windows 😉
@CLAassistant
Copy link

CLAassistant commented Jan 19, 2018

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@timsuchanek timsuchanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just tested it on Mac, it works. Thanks for the PR!

@timsuchanek timsuchanek merged commit d53500b into graphql:master May 28, 2018
cgxxv pushed a commit to cgxxv/graphql-playground that referenced this pull request Mar 25, 2022
We don't have `Cmd` available on windows 😉
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants