Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor dynamic styles #641

Merged
merged 29 commits into from
May 30, 2018
Merged

Editor dynamic styles #641

merged 29 commits into from
May 30, 2018

Conversation

huv1k
Copy link
Collaborator

@huv1k huv1k commented Apr 11, 2018

This PR introduces complete rewrite of editor styles. What are benefits of this approach?

  • Change of colors for editor (for future plugins)
  • Font family and font size can be introduced
  • One source of truth

This PR breaks light theme, because we need to test dark first and then make dynamical changing of all colors.

@huv1k huv1k changed the title WIP - Editor dynamic styles Editor dynamic styles May 7, 2018
@timsuchanek timsuchanek merged commit aa9dbc5 into master May 30, 2018
@huv1k huv1k deleted the editor-styles branch June 1, 2018 16:06
cgxxv pushed a commit to cgxxv/graphql-playground that referenced this pull request Mar 25, 2022
* First styling

* More transforming

* More refactoring done

* More refactoring

* Bottom editors done

* Variable and tracking editors

* Dynamic colors

* Almost done

* More stuff done

* Before last commit

* Finished dark

* Fix settings

* Fix docs

* Rebase

* Fix global styles

* Quicker then expected :D

* Dynamic fonts, cursors, finished light theme

* Result without subscriptions

* Remove endpoint

* disable sdl

* update deps

* Fix overflow and move cursor

* clean deps, add default settings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants