Add workspaceName prop #772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Before merging, please test if this solution works as I could not fully test the changes. The desired outcome would be a PlaygroundWrapper component which reacts to specific prop changes. To test it, one might create a component which passes changing endpoint props down to the PlaygroundWrapper/MiddlewareApp. |
timsuchanek
requested changes
Jul 30, 2018
| @@ -379,7 +387,9 @@ class PlaygroundWrapper extends React.Component< | |||
| fixedEndpoints={Boolean(this.state.configString)} | |||
| headers={this.state.headers} | |||
| configPath={this.props.configPath} | |||
| workspaceName={this.state.activeProjectName} | |||
| workspaceName={ | |||
| this.state.activeProjectName || this.props.workspaceName | |||
There was a problem hiding this comment.
Please change this to the other way around - this.props.workspaceName || ... as otherwise it's not possible to overwrite the workspaceName when using a graphql config
cgxxv
pushed a commit
to cgxxv/graphql-playground
that referenced
this pull request
Mar 25, 2022
* Fix announcement link * fix: add workspaceName prop to PlaygroundWrapper with passthrough to Playground * fix: Added mapPropsToState to react to prop changes * fix: remove unnecessary check * fix: swapped orders of workspaceName and activeProjectName
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #771
Changes proposed in this pull request: