Make schema reloading more resilient. Closes #940 #951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sult before sending another one" is default behavior when schema is reloading. The changes I made to account for this are unnecessary and actually cause polling to stop if the endpoint is unreachable.
|
Thanks for PR @timsuchanek 🚀 |
cgxxv
pushed a commit
to cgxxv/graphql-playground
that referenced
this pull request
Mar 25, 2022
* Make schema reloading more resilient. Closes graphql#940 * Regarding "If there’s an active introspection query, wait for it’s result before sending another one" is default behavior when schema is reloading. The changes I made to account for this are unnecessary and actually cause polling to stop if the endpoint is unreachable. * getIsPollingSchema catching regex error * add schema reference equality & printing cache * improve code readability * cleanup: remove dead code * fix build: use lru-cache. less unneeded repaints * fix lru cache usage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #.
Changes proposed in this pull request: