Reformat the parts of an execution request #1090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjie
added
the
✏️ Editorial
✅ Deploy Preview for graphql-spec-draft ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
mjmahone
approved these changes
Jun 6, 2024
|
|
||
| Given this information, the result of {ExecuteRequest()} produces the response, | ||
| to be formatted according to the Response section below. | ||
| - {schema}: The schema to use, typically solely provided by the GraphQL service. |
There was a problem hiding this comment.
nit and not-this-PR: GraphQL service is mildly ambiguous, it's the execution service or the executor or something like that?
There was a problem hiding this comment.
Also nit: GraphQL Service capitalized like below?
There was a problem hiding this comment.
We use this term across the spec I believe
| may contain {FragmentDefinition}. | ||
| - {operationName} (optional): The name of the Operation in the Document to | ||
| execute. | ||
| - {variableValues} (optional): Values for any Variables defined by the |
There was a problem hiding this comment.
nit and not-this-pr: it's not quite any variable: as you can omit some and must include others, but rather Values for a subset of Variables... but I'm not sure I can describe that in a more clarifying less ambiguous way.
JoviDeCroock
approved these changes
Jun 6, 2024
robrichard
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds names for each of the "pieces of information" that make up an execution request, and then shows how these values are passed into the
ExecuteRequest()algorithm.This is extracted from #976 as discussed at last night's working group. @leebyron
mentioned that this change adds clarity and is a positive editorial change; splitting this change out will help keep the "extensions" PR focused as it undergoes a few iterations.
cc @michaelstaib