-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFC] "Directive order is significant" section #470
Conversation
Forgot to mention that this RFC is the result of recent discussions in #429 and at the WG meetings. |
Are any changes necessary to GraphQL.js or Sangria to support this? |
@leebyron I believe no changes are necessary. RFC permits implementations to have a special treatment for directive order, but does not require it. Also, for all built-in directives, specific order is not important. |
This is a very reasonable clarification to the spec. In a project of ours, we actually rely on the order of directive definitions being preserved - which https://github.com/webonyx/graphql-php thankfully does already. Would be great to have this in to make this an explicitely defined rule that we can depend on. |
I would like to add a note on the directive ordering to make it more explicit. It is similar to the notes:
But it instead states that directive order is significant and may have specific semantic interpretation.