Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] "Directive order is significant" section #470

Merged
merged 1 commit into from
Aug 7, 2019

Conversation

OlegIlyenko
Copy link
Contributor

I would like to add a note on the directive ordering to make it more explicit. It is similar to the notes:

But it instead states that directive order is significant and may have specific semantic interpretation.

@OlegIlyenko
Copy link
Contributor Author

Forgot to mention that this RFC is the result of recent discussions in #429 and at the WG meetings.

@leebyron leebyron added 📄 Draft (RFC 2) RFC Stage 2 (See CONTRIBUTING.md) and removed RFC labels Oct 2, 2018
@leebyron
Copy link
Collaborator

leebyron commented Oct 2, 2018

Are any changes necessary to GraphQL.js or Sangria to support this?

@OlegIlyenko
Copy link
Contributor Author

@leebyron I believe no changes are necessary. RFC permits implementations to have a special treatment for directive order, but does not require it. Also, for all built-in directives, specific order is not important.

@spawnia
Copy link
Member

spawnia commented Apr 13, 2019

This is a very reasonable clarification to the spec. In a project of ours, we actually rely on the order of directive definitions being preserved - which https://github.com/webonyx/graphql-php thankfully does already.

Would be great to have this in to make this an explicitely defined rule that we can depend on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏁 Accepted (RFC 3) RFC Stage 3 (See CONTRIBUTING.md)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants