Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RFC: Schema Coordinates #746

Merged
merged 16 commits into from
Jan 7, 2021
Merged

RFC: Schema Coordinates #746

merged 16 commits into from
Jan 7, 2021

Commits on Oct 10, 2020

  1. Add Schema Coordinates RFC

    @magicmark
    magicmark committed Oct 10, 2020
    Configuration menu
    Copy the full SHA
    72438bf View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2020

  1. Update schema coordinates spec edit 

    - Make examples table
- Tweak the grammar definition
    @magicmark
    magicmark committed Nov 18, 2020
    Configuration menu
    Copy the full SHA
    3c9c8f9 View commit details
    Browse the repository at this point in the history

  2. move spec edits to seperate pr

    @magicmark
    magicmark committed Nov 18, 2020
    Configuration menu
    Copy the full SHA
    109e3c6 View commit details
    Browse the repository at this point in the history

  3. schema coordinates rfc: use colons for arguments

    @magicmark
    magicmark committed Nov 18, 2020
    Configuration menu
    Copy the full SHA
    e5ea9b5 View commit details
    Browse the repository at this point in the history

  4. schema coordinates rfc: fix newline

    @magicmark
    magicmark committed Nov 18, 2020
    Configuration menu
    Copy the full SHA
    fe62f67 View commit details
    Browse the repository at this point in the history

Commits on Nov 19, 2020

  1. Apply suggestions from code review 

    Co-authored-by: Benjie Gillam <benjie@jemjie.com>
    @magicmark @benjie
    magicmark and benjie authored Nov 19, 2020
    Configuration menu
    Copy the full SHA
    3cd6242 View commit details
    Browse the repository at this point in the history

  2. Update rfcs/SchemaCoordinates.md 

    Co-authored-by: Benjie Gillam <benjie@jemjie.com>
    @magicmark @benjie
    magicmark and benjie authored Nov 19, 2020
    Configuration menu
    Copy the full SHA
    9caf719 View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2020

  1. add notes about Foo.bar.baz vs Foo.bar(baz:)

    @magicmark
    magicmark committed Nov 21, 2020
    Configuration menu
    Copy the full SHA
    e423af3 View commit details
    Browse the repository at this point in the history

  2. fix broken link

    @magicmark
    magicmark committed Nov 21, 2020
    Configuration menu
    Copy the full SHA
    078bcfc View commit details
    Browse the repository at this point in the history

  3. add directive example

    @magicmark
    magicmark committed Nov 21, 2020
    Configuration menu
    Copy the full SHA
    f00ce54 View commit details
    Browse the repository at this point in the history

  4. emoji

    @magicmark
    magicmark committed Nov 21, 2020
    Configuration menu
    Copy the full SHA
    bfe9db9 View commit details
    Browse the repository at this point in the history

Commits on Jan 4, 2021

  1. capture discussion about argument syntax

    @magicmark
    magicmark committed Jan 4, 2021
    Configuration menu
    Copy the full SHA
    80f78a3 View commit details
    Browse the repository at this point in the history

  2. remove open question about argument syntax

    @magicmark
    magicmark committed Jan 4, 2021
    Configuration menu
    Copy the full SHA
    0ae4b46 View commit details
    Browse the repository at this point in the history

  3. add prior usage

    @magicmark
    magicmark committed Jan 4, 2021
    Configuration menu
    Copy the full SHA
    da052fe View commit details
    Browse the repository at this point in the history

  4. Update rfcs/SchemaCoordinates.md 

    Co-authored-by: Benjie Gillam <benjie@jemjie.com>
    @magicmark @benjie
    magicmark and benjie authored Jan 4, 2021
    Configuration menu
    Copy the full SHA
    1f9cfc6 View commit details
    Browse the repository at this point in the history

  5. Remove outdated section

    @magicmark
    magicmark committed Jan 4, 2021
    Configuration menu
    Copy the full SHA
    d8396c9 View commit details
    Browse the repository at this point in the history