Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow deprecation of input values (field args, directive args, input fields) #805

Merged
merged 7 commits into from
Jun 3, 2022
Merged

Allow deprecation of input values (field args, directive args, input fields) #805

merged 7 commits into from
Jun 3, 2022

Conversation

IvanGoncharov
Copy link
Member

@IvanGoncharov IvanGoncharov commented Dec 3, 2020 •
edited by leebyron
Loading

Continuation of #525 by @smitt04
Revisits #197 by @dylanahsmith

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Dec 3, 2020 •
edited
Loading

CLA Signed

The committers are authorized under a signed CLA.

@IvanGoncharov IvanGoncharov added 💡 Proposal (RFC 1) RFC Stage 1 (See CONTRIBUTING.md) 🚀 Next Stage? This RFC believes it is ready for the next stage labels Dec 3, 2020
maartenvanvliet added a commit to maartenvanvliet/absinthe that referenced this pull request Dec 20, 2020
@maartenvanvliet
Add introspection for deprecated args/input fields
9998a11 
Absinthe already supported deprecating args/input fields and this
PR exposes that in the introspection query to match the spec.

Also some tests were added for deprecating stuff.

See graphql/graphql-spec#805 for the spec update
Base automatically changed from master to main February 3, 2021 04:50
@glasser glasser mentioned this pull request Mar 9, 2021
Merged
@glasser glasser mentioned this pull request Apr 2, 2021
Closed
@leebyron
Copy link
Collaborator

@smitt04 would you mind signing the CLA (linked above) for your contribution?

@leebyron leebyron changed the title Allow deprecation of input values Allow deprecation of input values (field args, directive args, input fields) Apr 22, 2021
@leebyron leebyron mentioned this pull request Apr 22, 2021
Closed
@leebyron
Copy link
Collaborator

I've applied some editorial here, and I think this is good to go from a spec text point of view. The previous PR was moved to RFC2 and as discussed here graphql/graphql-wg#639 we have some next steps.

Notably on the JS side there is a missing piece compared to what this RFC proposes, tracked here: graphql/graphql-js#3048

There was also a question about validation being correct or having the right "breaking/dangerous changes" protections in place. @IvanGoncharov or other authors here have context on that?

@leebyron leebyron added 📄 Draft (RFC 2) RFC Stage 2 (See CONTRIBUTING.md) and removed 💡 Proposal (RFC 1) RFC Stage 1 (See CONTRIBUTING.md) 🚀 Next Stage? This RFC believes it is ready for the next stage labels Apr 22, 2021
@leebyron leebyron requested a review from a team April 22, 2021 22:47
@leebyron leebyron mentioned this pull request Apr 22, 2021
Closed
@leebyron leebyron force-pushed the main branch 4 times, most recently from e5d241d to 6c81ed8 Compare April 23, 2021 19:15
@michaelstaib
Copy link
Member

@IvanGoncharov Do we have any validation rule changes so that it is invalid to deprecate required arguments or required input fields?

@michaelstaib michaelstaib mentioned this pull request Apr 24, 2021
Closed
@smyrick smyrick mentioned this pull request Apr 30, 2021
Merged
@timbotnik timbotnik mentioned this pull request May 24, 2021
Open
@glasser glasser mentioned this pull request Jul 6, 2021
Merged
@spawnia spawnia mentioned this pull request Jul 29, 2021
Closed
@hwillson
Copy link
Member

👋 @leebyron - regarding:

Moved to S3: Accepted. I will do a final editorial review and merge into the draft. Great work everyone!

Now that the CLA has been signed, is there anything outstanding that is preventing this from being merged?

@jturkel jturkel mentioned this pull request May 5, 2022
Closed
@martinbonnin martinbonnin mentioned this pull request May 10, 2022
Merged
@benjie benjie mentioned this pull request May 23, 2022
Closed
@leebyron leebyron merged commit 94f73f4 into main Jun 3, 2022
@leebyron leebyron deleted the deprecate-args branch June 3, 2022 05:49
@flbraun flbraun mentioned this pull request Aug 18, 2022
Closed
dchang-dchang added a commit to dchang-dchang/graphql that referenced this pull request Aug 22, 2022
@dchang-dchang
Implement deprecation for arguments and input fields
9ef8c9b 
graphql/graphql-spec#805 changed the GraphQL
spec to allow deprecation on argument definitions and input field
definitions.
@mrtnzlml mrtnzlml mentioned this pull request Sep 17, 2022
Open
@steliosrammos steliosrammos mentioned this pull request Oct 20, 2022
Open
This was referenced Nov 1, 2022
Open
Draft
@sqs sqs mentioned this pull request Dec 18, 2022
Closed
@tomgasson tomgasson mentioned this pull request Mar 2, 2023
Closed
This was referenced Apr 3, 2023
Closed
Merged
Merged
@caruspi caruspi mentioned this pull request Apr 12, 2023
Closed
@newhouse newhouse mentioned this pull request Jun 12, 2023
Closed
@fotoetienne fotoetienne mentioned this pull request Jul 22, 2023
Closed
@brodin brodin mentioned this pull request Aug 22, 2023
Closed
@jhalborg jhalborg mentioned this pull request Sep 25, 2023
Closed
@juanscr juanscr mentioned this pull request Feb 29, 2024
Closed
Zain-Bin-Arshad added a commit to Zain-Bin-Arshad/graphql-ruby that referenced this pull request Mar 19, 2024
@Zain-Bin-Arshad
chore: removed warning for argument deprecation
ce46ef6 
It is now safe to remove this warning, this is merged and isn't a proposal anymore, see more  graphql/graphql-spec#805
@Zain-Bin-Arshad Zain-Bin-Arshad mentioned this pull request Mar 19, 2024
Merged
@dondonz dondonz mentioned this pull request May 8, 2024
Closed
@jhalborg jhalborg mentioned this pull request Jun 24, 2024
Open
@toxeus toxeus mentioned this pull request Oct 11, 2024
Open
@stuebingerb stuebingerb mentioned this pull request Oct 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leebyron leebyron leebyron left review comments

@rivantsov rivantsov rivantsov left review comments

@fotoetienne fotoetienne fotoetienne left review comments

@jturkel jturkel jturkel left review comments

@michaelstaib michaelstaib michaelstaib left review comments

@sungam3r sungam3r sungam3r left review comments

@benjie benjie benjie approved these changes

Assignees
No one assigned
Labels
🏁 Accepted (RFC 3) RFC Stage 3 (See CONTRIBUTING.md)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.