Factor out a package.team mixin #4422
Conversation
chadwhitacre
changed the title
| """ | ||
| return cursor.one( 'SELECT t.*::teams FROM teams t WHERE t.id=' | ||
| '(SELECT team_id FROM teams_to_packages tp WHERE tp.package_id=%s)' | ||
| , (self.id,) |
There was a problem hiding this comment.
Might be my recent lack of exposure to Python mixin classes, but this actually feels a bit backward. You mix it in with Package, but instead of Package leveraging some of the functionality of the mixed-in Team, Team leverages things like self.id that must be in Package.
There was a problem hiding this comment.
It's consumers that leverage the synergies contained herein, not necessarily the main Package object itself. The goal here is to keep files reasonably sized (well under 1,000 lines ideally), and the architecture is to have a main Package class (e.g.) that is essentially a container, with API provided by these mixins. But the API itself is called primarily by other objects.
Does that make any sense?
There was a problem hiding this comment.
Yeah, that makes sense. It seems like the API of Package is a little more opaque that way. It more hides the complexity due to lines of code (if any) than reduces it. But it's no reason to hold up this PR - just my thoughts on the matter now. ;-)
dowski
changed the base branch from
project/claim-packages-edit
to
project/claim-packages
Part of #4305, follows on #4404.
Minor refactor. Ready for review.