Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tsh puttyconfig doesn't work if proxy templates are defined #45565

Closed
rosstimothy opened this issue Aug 16, 2024 · 0 comments · Fixed by #46291
Closed

tsh puttyconfig doesn't work if proxy templates are defined #45565

rosstimothy opened this issue Aug 16, 2024 · 0 comments · Fixed by #46291
Assignees
@rosstimothy
Labels
bug c-mzz Internal Customer Reference server-access tsh tsh - Teleport's command line tool for logging into nodes running Teleport.

Comments

@rosstimothy
Copy link
Contributor

Expected behavior:

tsh puttyconfig user@host works regardless of any proxy templates defined in $TSH_HOME/config/config.yaml

Current behavior:

If there is a proxy template defined, the hostname provided to tsh puttyconfig may be set to "" and result in the following error.

tsh puttyconfig foo@bar
ERROR: provided hostname  does not look like a valid hostname. Make sure it doesn't contain illegal characters.
@zmb3 zmb3 added tsh tsh - Teleport's command line tool for logging into nodes running Teleport. server-access labels Aug 16, 2024
@WilliamLoy WilliamLoy added the c-mzz Internal Customer Reference label Sep 4, 2024
rosstimothy added a commit that referenced this issue Sep 5, 2024
@rosstimothy
Respect proxy templates in tsh puttyconfig
6f6dc57 
Updates tsh puttyconfig to resolve hosts appropriately if a match
is found in the users defined proxy templates.

Fixes #45565
rosstimothy added a commit that referenced this issue Sep 5, 2024
@rosstimothy
Respect proxy templates in tsh puttyconfig
f81f5d8 
Updates tsh puttyconfig to resolve hosts appropriately if a match
is found in the users defined proxy templates.

Fixes #45565
@rosstimothy rosstimothy mentioned this issue Sep 5, 2024
Merged
@rosstimothy rosstimothy self-assigned this Sep 5, 2024
rosstimothy added a commit that referenced this issue Sep 5, 2024
@rosstimothy
Respect proxy templates in tsh puttyconfig
1b4c665 
Updates tsh puttyconfig to resolve hosts appropriately if a match
is found in the users defined proxy templates.

Fixes #45565
rosstimothy added a commit that referenced this issue Sep 6, 2024
@rosstimothy
Respect proxy templates in tsh puttyconfig
2e658a5 
Updates tsh puttyconfig to resolve hosts appropriately if a match
is found in the users defined proxy templates.

Fixes #45565
github-merge-queue bot pushed a commit that referenced this issue Sep 9, 2024
@rosstimothy
Respect proxy templates in tsh puttyconfig (#46291)
49fd078 
Updates tsh puttyconfig to resolve hosts appropriately if a match
is found in the users defined proxy templates.

Fixes #45565
github-actions bot pushed a commit that referenced this issue Sep 9, 2024
@rosstimothy
Respect proxy templates in tsh puttyconfig
d6fdd19 
Updates tsh puttyconfig to resolve hosts appropriately if a match
is found in the users defined proxy templates.

Fixes #45565
rosstimothy added a commit that referenced this issue Sep 9, 2024
@rosstimothy
Respect proxy templates in tsh puttyconfig (#46291)
b69fafe 
Updates tsh puttyconfig to resolve hosts appropriately if a match
is found in the users defined proxy templates.

Fixes #45565
rosstimothy added a commit that referenced this issue Sep 9, 2024
@rosstimothy
Respect proxy templates in tsh puttyconfig (#46291)
bd86482 
Updates tsh puttyconfig to resolve hosts appropriately if a match
is found in the users defined proxy templates.

Fixes #45565
github-merge-queue bot pushed a commit that referenced this issue Sep 9, 2024
@rosstimothy
Respect proxy templates in tsh puttyconfig (#46384)
6ca497c 
Updates tsh puttyconfig to resolve hosts appropriately if a match
is found in the users defined proxy templates.

Fixes #45565
mvbrock pushed a commit that referenced this issue Sep 10, 2024
@rosstimothy @mvbrock
Respect proxy templates in tsh puttyconfig (#46291)
a5959f5 
Updates tsh puttyconfig to resolve hosts appropriately if a match
is found in the users defined proxy templates.

Fixes #45565
rosstimothy added a commit that referenced this issue Sep 11, 2024
@rosstimothy
Respect proxy templates in tsh puttyconfig (#46291)
bfebd30 
Updates tsh puttyconfig to resolve hosts appropriately if a match
is found in the users defined proxy templates.

Fixes #45565
github-merge-queue bot pushed a commit that referenced this issue Sep 11, 2024
@rosstimothy
Respect proxy templates in tsh puttyconfig (#46291) (#46385)
3a6f7c8 
Updates tsh puttyconfig to resolve hosts appropriately if a match
is found in the users defined proxy templates.

Fixes #45565
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rosstimothy rosstimothy

Labels
bug c-mzz Internal Customer Reference server-access tsh tsh - Teleport's command line tool for logging into nodes running Teleport.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Respect proxy templates in tsh puttyconfig gravitational/teleport
3 participants
@zmb3 @WilliamLoy @rosstimothy