Fix CLI reference for the tsh --ttl flag #13489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ugh, this stinks. It's a duration for Hopefully work towards a CLI style guide can prevent things like this going forward. |
zmb3
approved these changes
Jun 14, 2022
r0mant
approved these changes
Jun 14, 2022
The value of the --ttl flag for tsh commands was incorrectly stated to be a duration. Instead, it is an integer indicating a number of minutes. The default is 12 hours. Also does some minor copy-editing on the tsh global flags.
ptgott
force-pushed
the
paul.gottschling/2022-06-14-tsh-ttl
branch
from
c8252ea
to
248b696
Compare
ptgott
added a commit
that referenced
this pull request
Jun 16, 2022
Backports #13489 The value of the --ttl flag for tsh commands was incorrectly stated to be a duration. Instead, it is an integer indicating a number of minutes. The default is 12 hours. Also does some minor copy-editing on the tsh global flags.
ptgott
added a commit
that referenced
this pull request
Jun 21, 2022
Backports #13489 The value of the --ttl flag for tsh commands was incorrectly stated to be a duration. Instead, it is an integer indicating a number of minutes. The default is 12 hours. Also does some minor copy-editing on the tsh global flags.
ptgott
added a commit
that referenced
this pull request
Jul 7, 2022
Backports #13489 The value of the --ttl flag for tsh commands was incorrectly stated to be a duration. Instead, it is an integer indicating a number of minutes. The default is 12 hours. Also does some minor copy-editing on the tsh global flags.
ptgott
added a commit
that referenced
this pull request
Jul 12, 2022
Backports #13489 The value of the --ttl flag for tsh commands was incorrectly stated to be a duration. Instead, it is an integer indicating a number of minutes. The default is 12 hours. Also does some minor copy-editing on the tsh global flags.
ptgott
added a commit
that referenced
this pull request
Jul 12, 2022
Fix CLI reference for the tsh --ttl flag Backports #13489 The value of the --ttl flag for tsh commands was incorrectly stated to be a duration. Instead, it is an integer indicating a number of minutes. The default is 12 hours. Also does some minor copy-editing on the tsh global flags.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The value of the --ttl flag for tsh commands was incorrectly stated to
be a duration. Instead, it is an integer indicating a number of minutes.
The default is 12 hours.
Also does some minor copy-editing on the tsh global flags.