Pick correct cert when signing Connect #15344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zmb3
approved these changes
Aug 9, 2022
marcoandredinis
approved these changes
Aug 9, 2022
|
I verified that 11.0.0-dev.13 still works and since this PR got approved already I'm just going to merge it. |
|
@ravicious See the table below for backport results.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are multiple Apple Developer ID certs available on our darwin build machines. By default, electron-builder tries to automatically pick one that can be used for signing the app.
However, in gravitational/webapps#1033 we're trying to grant access to Connect so that it can use the same Touch ID Secure Enclave keys as tsh.app. To do that we need to distribute a provisioning profile. A provisioning profile is bound to a single specific Apple Developer ID. Alan and I made it so that the provisioning profile for Connect is going to be bound to the same Dev ID as the provisioning profile for tsh.app.
Unfortunately, the Dev ID cert picked by default by electron-builder is not the one bound to the provisioning profile. This PR makes it so that the correct Dev ID is picked.
This change shouldn't have any effect on the whole process until we add the provisioning profile but I'm making a tag build to verify again that this change doesn't break the signing process. I'll post a link to the signed build once Drone uploads the build.