Fix duplicate entry for X-Forwarded-For header
#32039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zmb3
approved these changes
Sep 18, 2023
PR #27761 replaced `oxy.Forwarder` with `httputil.ReverseProxy`. The new forwarder based on `httputil.ReverseProxy` is appending the `X-Forwarder-For` header values instead of replacing them. This PR fixes that behavior and forces the XFF header to be a single value. Signed-off-by: Tiago Silva <tiago.silva@goteleport.com>
tigrato
force-pushed
the
tigrato/fix-duplicated-xff
branch
from
2673a0a
to
4bcd2e8
Compare
reedloden
reviewed
Sep 18, 2023
Co-authored-by: Reed Loden <reed@goteleport.com>
AntonAM
approved these changes
Sep 18, 2023
public-teleport-github-review-bot
bot
removed the request for review
from EdwardDowling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #27761 replaced
oxy.Forwarderwithhttputil.ReverseProxy.The new forwarder based on
httputil.ReverseProxyis appending theX-Forwarder-Forheader values instead of replacing them. This PR fixes that behavior and forces the XFF header to be a single value.