Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the Access List review backend. #32924

Merged
merged 8 commits into from
Oct 5, 2023
Merged

Add the Access List review backend. #32924

merged 8 commits into from
Oct 5, 2023

Conversation

mdwn
Copy link
Contributor

@mdwn mdwn commented Oct 3, 2023

The Access List review backend has been added to Teleport.

Depends on:

Base automatically changed from mike.wilson/access-list-recurrence-presets to master October 3, 2023 22:54
Add the Access List review backend.
337f733 
The Access List review backend has been added to Teleport.
@mdwn mdwn force-pushed the mike.wilson/access-review-backend-service branch from e7bfac1 to 337f733 Compare October 4, 2023 12:45
rosstimothy
rosstimothy reviewed Oct 5, 2023
View reviewed changes
lib/services/access_list.go Outdated Show resolved Hide resolved
lib/services/access_list.go Outdated Show resolved Hide resolved
lib/services/access_list.go Outdated Show resolved Hide resolved
lib/services/access_list.go Show resolved Hide resolved
lib/services/access_list.go Show resolved Hide resolved
mdwn and others added 2 commits October 5, 2023 10:32
@mdwn @rosstimothy
Update lib/services/access_list.go
e5f37ef 
Co-authored-by: rosstimothy <39066650+rosstimothy@users.noreply.github.com>
@mdwn @rosstimothy
Update lib/services/access_list.go
b41dccd 
Co-authored-by: rosstimothy <39066650+rosstimothy@users.noreply.github.com>
rosstimothy
rosstimothy reviewed Oct 5, 2023
View reviewed changes
lib/services/access_list.go Outdated Show resolved Hide resolved
lib/services/access_list.go Show resolved Hide resolved
lib/services/access_list.go Outdated Show resolved Hide resolved
api/client/accesslist/accesslist.go Outdated Show resolved Hide resolved
api/client/accesslist/accesslist.go Show resolved Hide resolved
GavinFrazar
GavinFrazar approved these changes Oct 5, 2023
View reviewed changes
api/proto/teleport/accesslist/v1/accesslist_service.proto Outdated Show resolved Hide resolved
lib/services/local/access_list.go Outdated Show resolved Hide resolved
lib/services/local/access_list.go Outdated Show resolved Hide resolved
lib/services/local/access_list.go Outdated Show resolved Hide resolved
lib/services/local/access_list_test.go Show resolved Hide resolved
rosstimothy
rosstimothy reviewed Oct 5, 2023
View reviewed changes
lib/services/access_list.go Show resolved Hide resolved
lib/services/local/access_list.go Outdated Show resolved Hide resolved
@public-teleport-github-review-bot public-teleport-github-review-bot bot removed the request for review from tigrato October 5, 2023 20:17
@mdwn mdwn added this pull request to the merge queue Oct 5, 2023
Merged via the queue into master with commit ed488aa Oct 5, 2023
31 checks passed
@mdwn mdwn deleted the mike.wilson/access-review-backend-service branch October 5, 2023 20:49
@public-teleport-github-review-bot
Copy link

@mdwn See the table below for backport results.

Branch Result
branch/v13 Failed
branch/v14 Failed

@public-teleport-github-review-bot
Copy link

@mdwn See the table below for backport results.

Branch Result
branch/v13 Failed
branch/v14 Failed

This was referenced Oct 6, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rosstimothy rosstimothy rosstimothy approved these changes

@GavinFrazar GavinFrazar GavinFrazar approved these changes

Assignees
No one assigned
Labels
backport/branch/v13 backport/branch/v14 size/lg
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mdwn @GavinFrazar @rosstimothy