Web build: patch circular dep warnings #32941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gzdunek
approved these changes
Oct 4, 2023
zmb3
approved these changes
Oct 4, 2023
public-teleport-github-review-bot
bot
removed the request for review
from ravicious
This was referenced Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
enterprise: https://github.com/gravitational/teleport.e/pull/2349
gets rid of circular dependency warnings when building for production.
i don't think this quick "patch" was the root issue, i turned on eslint for
import/no-cycleand there were kinda everywhere 🙈i was planning to add the rule as a warning to help us avoid for future, but with this one, the linter takes about 3-4 minutes to complete, without it takes like less than a minute (docs does says its computationally expensive), i opted to leave it out unless someone disagrees.
i created an issue for myself to tackle some of it later: #32940