[v13] Add in audit review recurrence presets. #32961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Access Lists now have audit review recurrence presets. These allow users to specify review frequencies of 1, 3, 6, or 12 months, and specify the 1st, 15th, or last days of the target month. Presets have been used for their simplicity over other various recurrence definition mechanisms, as these presets are much clearer than many of the other options.
espadolini
changed the title
espadolini
requested review from
r0mant and
jakule
and removed request for
espadolini and
rudream
r0mant
approved these changes
Oct 4, 2023
jakule
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #32843 to branch/v13.
Access Lists now have audit review recurrence presets. These allow users to specify review frequencies of 1, 3, 6, or 12 months, and specify the 1st, 15th, or last days of the target month. Presets have been used for their simplicity over other various recurrence definition mechanisms, as these presets are much clearer than many of the other options.
Note: This was a manual backport. The two conflicts were the ordering in the
cache_tests.go, and thatunified_resource_test.godoesn't exist in v13.