Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement autostart for VNet in Connect #40900

Merged
merged 9 commits into from
Apr 26, 2024
Merged

Implement autostart for VNet in Connect #40900

merged 9 commits into from
Apr 26, 2024

Commits on Apr 25, 2024

  1. Refactor tests that depended on workspace service state 

    Those tests explicitly set the entire WorkspacesService state and would
have to be modified each time we added something to the state.

There's no reason for them to know about WorkspacesService state, so this
commit refactors them out of that knowledge.
    @ravicious
    ravicious committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    04532f3 View commit details
    Browse the repository at this point in the history

  2. Add useAppState

    @ravicious
    ravicious committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    9f1a8d8 View commit details
    Browse the repository at this point in the history

  3. Automatically start VNet

    @ravicious
    ravicious committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    927c672 View commit details
    Browse the repository at this point in the history

  4. subscribeWithSelector: Return unsubscribe function 

    The unsubscribe function will be needed in order to comply with
useSyncExternalStore API in the next commit.
    @ravicious
    ravicious committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    cd8f2f3 View commit details
    Browse the repository at this point in the history

  5. Add isInitialized to WorkspacesService

    @ravicious
    ravicious committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    20a6874 View commit details
    Browse the repository at this point in the history

  6. Add useImmutableStore

    @ravicious
    ravicious committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    40edc18 View commit details
    Browse the repository at this point in the history

  7. Wait for workspace init before VNet autostart

    @ravicious
    ravicious committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    492f7cb View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2024

  1. Rename useAppState to usePersistedState

    @ravicious
    ravicious committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    18626a5 View commit details
    Browse the repository at this point in the history

  2. Rename useImmutableStore to useStoreSelector

    @ravicious
    ravicious committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    0d64323 View commit details
    Browse the repository at this point in the history