-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add yarn ecosystem to dependabot.yaml #42942
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so this may need to be iterated on (validate in the sense of, "hey this is going to work as we expect", not syntactically).
Welcome to the magical world of dependency management.
.github/dependabot.yml
Outdated
interval: monthly | ||
day: "sunday" | ||
time: "09:00" # 9am UTC | ||
open-pull-requests-limit: 10 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You might want to bump this if you think we are getting a storm of deps. Same for others.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I went back and forth between "we're getting a lot so open the flood gates" and "we're getting a lot so let's try to limit it". I'm happy either way. Let's see if anyone has anything else to say
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you anticipate a lot of updates out of the gate it might be worth trying to manually update them first. Botty can get a little confused and conflicted if it has lots of updates to process.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just merged in a bunch of patch updates. I'm going to try and update the minor updates before this goes in. I'll also bump this to 20. We typically don't have too many deps for each of the repos, but combined it might add up. (i wish we could group it together)
Once this is in, I'll do the same for |
This PR should enable dependabot to check our web UI ecosystem. We use yarn workspaces so (I believe) we have to target each individual package.json in order for it to be updated. As far as I'm aware, I haven't found a way to [validate a dependabot.yaml file before letting it run](dependabot/dependabot-core#4605) so this may need to be iterated on. I've tried to split up the responsibility for each package around the web team (connect team takes /teleterm, ryan helps with /build). Change ecosystem name to npm According to the docs, although yarn is a valid ecosystem, the job is now asking for npm. I'm not sure if this will use yarn to update the yarn.lock or not
This PR should enable dependabot to check our web UI ecosystem. We use yarn workspaces so (I believe) we have to target each individual package.json in order for it to be updated. As far as I'm aware, I haven't found a way to validate a dependabot.yaml file before letting it run so this may need to be iterated on (validate in the sense of, "hey this is going to work as we expect", not syntactically).
I've tried to split up the responsibility for each package around the web team (connect team takes /teleterm, ryan helps with /build).
I suspect we will get quite a bit of noise at the start since most of our deps are out of date (some more than others) but after the initial push, it should be minimal as time goes on.