Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Bot Instances during initial bot join #43577

Merged
merged 10 commits into from
Jul 3, 2024

Commits on Jun 27, 2024

  1. Create Bot Instances during initial bot join

    This creates new instances for bots when they initially join the
    cluster, and persists instance IDs in new certificate fields on join
    and during renewal.
    
    Note that this does not yet handle instance reuse for non-token join
    methods.
    
    Additionally, bot instance creation is locked behind a
    `BOT_INSTANCE_EXPERIMENT` flag; it must be set to `1` to enable
    creation.
    timothyb89 committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    e15e1d2 View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2024

  1. Proto cleanup, and update bot auth records on cert renewal

    This makes various (admittedly breaking) protobuf changes, including
    removing the TTL field (calculating resource expiry based on cert
    requests), removing public key fingerprints, and changing the data
    type of the generation counter to match the preexisting internal
    datatype. These changes _should_ be safe as no consumers of the proto
    API currently exist.
    
    Additionally, this also updates bot authentications on renewal.
    timothyb89 committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    c0b7dc8 View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2024

  1. Fix proto lints

    timothyb89 committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    208ed2f View commit details
    Browse the repository at this point in the history

Commits on Jul 2, 2024

  1. Configuration menu
    Copy the full SHA
    d7e1524 View commit details
    Browse the repository at this point in the history
  2. Create bot instances for old bots on join; other fixes

    This now creates bot instances for bots whose certs are missing the
    BotInstanceID field. Additionally, it fixes two related bugs:
    expiration dates are extended on renewal, the generated UUID
    is properly appended to certs on initial join, and instances are
    only created or updated when the experiment is enabled.
    timothyb89 committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    64e0a52 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    c1a9833 View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2024

  1. Configuration menu
    Copy the full SHA
    56bbc64 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0a813a0 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    5aa2374 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    bed3e45 View commit details
    Browse the repository at this point in the history