-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create Bot Instances during initial bot join #43577
Merged
Merged
Commits on Jun 27, 2024
-
Create Bot Instances during initial bot join
This creates new instances for bots when they initially join the cluster, and persists instance IDs in new certificate fields on join and during renewal. Note that this does not yet handle instance reuse for non-token join methods. Additionally, bot instance creation is locked behind a `BOT_INSTANCE_EXPERIMENT` flag; it must be set to `1` to enable creation.
Configuration menu - View commit details
-
Copy full SHA for e15e1d2 - Browse repository at this point
Copy the full SHA e15e1d2View commit details
Commits on Jun 28, 2024
-
Proto cleanup, and update bot auth records on cert renewal
This makes various (admittedly breaking) protobuf changes, including removing the TTL field (calculating resource expiry based on cert requests), removing public key fingerprints, and changing the data type of the generation counter to match the preexisting internal datatype. These changes _should_ be safe as no consumers of the proto API currently exist. Additionally, this also updates bot authentications on renewal.
Configuration menu - View commit details
-
Copy full SHA for c0b7dc8 - Browse repository at this point
Copy the full SHA c0b7dc8View commit details
Commits on Jul 1, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 208ed2f - Browse repository at this point
Copy the full SHA 208ed2fView commit details
Commits on Jul 2, 2024
-
Configuration menu - View commit details
-
Copy full SHA for d7e1524 - Browse repository at this point
Copy the full SHA d7e1524View commit details -
Create bot instances for old bots on join; other fixes
This now creates bot instances for bots whose certs are missing the BotInstanceID field. Additionally, it fixes two related bugs: expiration dates are extended on renewal, the generated UUID is properly appended to certs on initial join, and instances are only created or updated when the experiment is enabled.
Configuration menu - View commit details
-
Copy full SHA for 64e0a52 - Browse repository at this point
Copy the full SHA 64e0a52View commit details -
Configuration menu - View commit details
-
Copy full SHA for c1a9833 - Browse repository at this point
Copy the full SHA c1a9833View commit details
Commits on Jul 3, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 56bbc64 - Browse repository at this point
Copy the full SHA 56bbc64View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0a813a0 - Browse repository at this point
Copy the full SHA 0a813a0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5aa2374 - Browse repository at this point
Copy the full SHA 5aa2374View commit details -
Configuration menu - View commit details
-
Copy full SHA for bed3e45 - Browse repository at this point
Copy the full SHA bed3e45View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.