Update wasm-pack to 0.13.1 #44218
Merged
Update wasm-pack to 0.13.1 #44218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In draft until I can complete a tag build. |
zmb3
added
backport/branch/v14
no-changelog
jakule
approved these changes
Jul 15, 2024
|
Tag build has some failures, some seem related but others look transient: https://github.com/gravitational/teleport.e/actions/runs/10001732513/job/27645901952 I'll let this sit for a while and revisit after Cam's new cross-compiling buildbox lands. |
zmb3
force-pushed
the
zmb3/wasm-pack-13
branch
from
260f5b8
to
e67a09d
Compare
|
Running a new tag build: https://github.com/gravitational/teleport.e/actions/workflows/tag-build.yaml Looks like this one fails too. @camscale any ideas? |
zmb3
force-pushed
the
zmb3/wasm-pack-13
branch
from
e67a09d
to
f2adcc9
Compare
|
Looks like wasm-pack 0.13 now requires cmake to be installed on the host due to a new transitive dependency. A PR to fix this was merged months ago, but wasm-pack hasn't made a new release including the change. See also rustwasm/wasm-pack#1426 |
zmb3
force-pushed
the
zmb3/wasm-pack-13
branch
from
8b061ef
to
c05adeb
Compare
zmb3
force-pushed
the
zmb3/wasm-pack-13
branch
from
c05adeb
to
1f16c9a
Compare
zmb3
requested review from
rosstimothy and
jakule
and removed request for
jakule
rosstimothy
approved these changes
Oct 29, 2024
r0mant
approved these changes
Oct 30, 2024
public-teleport-github-review-bot
bot
removed the request for review
from atburke
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.