Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update wasm-pack to 0.13.1 #44218

Merged
merged 1 commit into from
Oct 30, 2024
Merged

Update wasm-pack to 0.13.1 #44218

merged 1 commit into from
Oct 30, 2024

Conversation

zmb3
Copy link
Collaborator

@zmb3 zmb3 commented Jul 15, 2024

No description provided.

@zmb3
Copy link
Collaborator Author

zmb3 commented Jul 15, 2024

In draft until I can complete a tag build.

@zmb3 zmb3 added backport/branch/v14 no-changelog Indicates that a PR does not require a changelog entry backport/branch/v15 backport/branch/v16 labels Jul 15, 2024
Copy link
Contributor

@jakule jakule left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, assuming that the tag build works.

@zmb3
Copy link
Collaborator Author

zmb3 commented Jul 19, 2024

Tag build has some failures, some seem related but others look transient: https://github.com/gravitational/teleport.e/actions/runs/10001732513/job/27645901952

I'll let this sit for a while and revisit after Cam's new cross-compiling buildbox lands.

@zmb3
Copy link
Collaborator Author

zmb3 commented Sep 18, 2024

Running a new tag build: https://github.com/gravitational/teleport.e/actions/workflows/tag-build.yaml

Looks like this one fails too. @camscale any ideas?

@camscale
Copy link
Contributor

Looks like this one fails too. @camscale any ideas?

@zmb3 I'll look into this in the coming week - I'm back to migrating the build to the new buildbox so I'll see how it goes with the new version of wasm-pack.

@zmb3
Copy link
Collaborator Author

zmb3 commented Oct 29, 2024

Looks like wasm-pack 0.13 now requires cmake to be installed on the host due to a new transitive dependency.

A PR to fix this was merged months ago, but wasm-pack hasn't made a new release including the change.

See also rustwasm/wasm-pack#1426

@zmb3 zmb3 changed the title Update wasm-pack to 0.13.0 Update wasm-pack to 0.13.1 Oct 29, 2024
@zmb3 zmb3 marked this pull request as ready for review October 29, 2024 20:56
@zmb3 zmb3 requested review from rosstimothy and jakule and removed request for jakule October 29, 2024 21:10
Copy link
Contributor

@jakule jakule left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zmb3 zmb3 added this pull request to the merge queue Oct 30, 2024
Merged via the queue into master with commit ffeb49f Oct 30, 2024
39 checks passed
@zmb3 zmb3 deleted the zmb3/wasm-pack-13 branch October 30, 2024 15:41
@public-teleport-github-review-bot

@zmb3 See the table below for backport results.

Branch Result
branch/v15 Failed
branch/v16 Failed
branch/v17 Create PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants