Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reuse existing SAMLConnector signing key when possible #44655

Merged
merged 2 commits into from
Jul 25, 2024

Conversation

hugoShaka
Copy link
Contributor

@hugoShaka hugoShaka commented Jul 25, 2024

Fixes #9104

Changelog: Teleport no longer creates invalid SAML Connectors when calling tctl get saml/<connector-name> | tctl create -f without the --with-secrets flag.

Copy link

The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with changelog: followed by the changelog entries for the PR.

@public-teleport-github-review-bot public-teleport-github-review-bot bot removed the request for review from AntonAM July 25, 2024 20:21
@hugoShaka hugoShaka enabled auto-merge July 25, 2024 20:31
@hugoShaka hugoShaka added this pull request to the merge queue Jul 25, 2024
Merged via the queue into master with commit c8e4e76 Jul 25, 2024
38 checks passed
@hugoShaka hugoShaka deleted the hugo/fix-saml-empty-pkey-footgun branch July 25, 2024 21:28
@public-teleport-github-review-bot

@hugoShaka See the table below for backport results.

Branch Result
branch/v14 Failed
branch/v15 Failed
branch/v16 Create PR

tigrato pushed a commit that referenced this pull request Sep 23, 2024
* Reuse existing SAMLConnector signing key when possible

* lint
github-merge-queue bot pushed a commit that referenced this pull request Sep 24, 2024
* Reuse existing SAMLConnector signing key when possible

* lint

Co-authored-by: Hugo Shaka <hugo.hervieux@goteleport.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Teleport allows creating a SAML connector with empty signing_key
3 participants