Update AWS roles ARNs displayed on `tsh app login` for AWS console apps #44983

gabrielcorado · 2024-08-01T20:15:54Z

Closes https://github.com/gravitational/customer-sensitive-requests/issues/303 and #44410.

Update tsh to display AWS roles ARNs from root and leaf clusters (when applicable) instead of returning the roles from the profile. This update matches the results shown on Web UI (updated by #44611).

The flow is the same used by the API endpoint called by the Web UI:

Fetch the applications using GetEnrichedResourcesPage, and use the Logins field to present the available roles ARNs.
If the Logins field is empty (due to an older version of the server), fallback to retrieving the logins using the access checker GetAllowedLoginsForResource. This fallback can be removed in later versions (the same as the Web UI changes).

changelog: Correctly display available allowed logins of leaf AWS Console Apps on tsh app login.

github-actions · 2024-08-01T20:16:28Z

The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with changelog: followed by the changelog entries for the PR.

This is being covered on another PR.

greedy52

Overall LGTM and tested 🎉 . Left a few comments.

lib/client/api.go

lib/client/api_test.go

tool/tsh/common/app_aws.go

tool/tsh/common/app.go

… ready

lib/client/api.go

tool/tsh/common/app.go

…client

gabrielcorado · 2024-08-09T00:43:44Z

@greedy52 @rosstimothy I've updated the PR to list the apps using api/client.GetEnrichedResourcePage directly (similar to DB commands). Also, I've updated the getAppInfo to return the used cluster client so other functions can reuse it instead of creating multiple connections.

tool/tsh/common/app.go

greedy52 · 2024-08-14T13:03:27Z

tool/tsh/common/app.go

-	err = client.RetryWithRelogin(ctx, tc, func() error {
-		apps, err = tc.ListApps(ctx, &proto.ListResourcesRequest{
-			Namespace:           tc.Namespace,
+func getApp(ctx context.Context, tc *client.TeleportClient, clt apiclient.GetResourcesClient, name string) (app types.Application, logins []string, err error) {


nit: maybe add a trace?

gabrielcorado · 2024-08-30T03:47:21Z

@rosstimothy Tests should be fixed now. The flaky detector is failing due to timeout, and we might need to exclude TestAWSConsoleLogins (which takes 16s on average to complete)

rosstimothy · 2024-09-01T22:14:40Z

@rosstimothy Tests should be fixed now. The flaky detector is failing due to timeout, and we might need to exclude TestAWSConsoleLogins (which takes 16s on average to complete)

Is there anything that we can do to make TestAWSConsoleLogins faster?

gabrielcorado · 2024-09-02T13:50:31Z

Is there anything that we can do to make TestAWSConsoleLogins faster?

All three of my modified tests (TestAzure, TestAWS, and TestAWSConsoleLogins) are timing out. Most of the time spent on those tests is setting up the clusters.

As for TestAWSConsoleLogins, we could split it into two parts: one for the root cluster (which will require a single cluster) and another for the leaf (which requires root and leaf cluster). This split would not guarantee the first test to pass (on my machine, it took, on average, 11s). The second test still averages (15s) to complete, so it will most likely time out.

rosstimothy · 2024-09-04T13:01:13Z

/excludeflake *

…gravitational/teleport into gabrielcorado/tsh-app-login-leaf-logins

rosstimothy · 2024-09-19T12:09:36Z

@gabrielcorado what's the status on this? Are we good to merge?

public-teleport-github-review-bot · 2024-09-19T19:16:06Z

@gabrielcorado See the table below for backport results.

Branch	Result
branch/v16	Failed

…ps (#44983) * feat(tsh): list aws console logins from server * chore(services): remove unified resources change This is being covered on another PR. * test(tsh): solve TestAzure flakiness by waiting using app servers are ready * fix(tsh): apps with logins were fallingback into using aws arns * refactor(client): use GetEnrichedResources * chore(client): rename function * refactor(tsh): directly resource lisiting for apps and reuse cluster client * chore(client): reset client changes * refactor(tsh): reuse cluster client for fetching allowed logins * chore(tsh): remove unused function param * refactor(tsh): update getApp retry with login * refactor(tsh): use a single function to grab profile and cluste client * refactor(tsh): perform retry with login at caller site * fix(tsh): close auth client * test(tsh): fix test failing due to login misconfiguration * test(tsh): fix lint errors * test(tsh): remove unused imports

* Displaying mode and controls to additional participants * Moving SessionControlsInfoBroadcast over to kube/proxy * Transitioning to consistent proxy-emitted mode+controls * Moving message broadcast so new participant wont see it * Possible unit test fix (cant seem to test locally) * Fixed unit test * Adding a line break before messaging the participant * Linter errors * Emitting audit event and controls message for additional parties, i.e. not the session initiator * Revert "Emitting audit event and controls message for additional parties, i.e. not the session initiator" This reverts commit b66ad27. * Add User Tasks resource - protos (#46059) * Add User Integration Tasks resource - protos * add account id * move state to task instead of instance * rename from user integration task to user task * add instance id * Add notice to web UI that users arent equal to MAU (#46686) This adds a dismissible notice to the Users page for usage based billing users that notifies them that the user count here isn't an accurate reflection of MAU * Clarify TLS requirements in the Jira guide (#46484) Closes #45654 - Indicate that certificates for the Jira web server cannot be self signed. - Remove references to Caddy and a `Certificate` resource, which were left over from an attempted change to this guide that was not fully completed. * Remove TXT record validation of custom DNS zones in VNet (#46709) * Remove TXT record validation from custom DNS zones * Remove mentions of TXT records from docs * Outline in the RFD why domain verification was dropped * Update rfd/0163-vnet.md Co-authored-by: Nic Klaassen <nic@goteleport.com> --------- Co-authored-by: Nic Klaassen <nic@goteleport.com> * docs: mention the --days flag when executing an audit log query (#45764) * Update access-monitoring.mdx Include the default date range in the CLI example. This range is otherwise unclear and is hidden in the tctl audit help menu. * Update access-monitoring.mdx * Update docs/pages/admin-guides/access-controls/access-monitoring.mdx Co-authored-by: Zac Bergquist <zac.bergquist@goteleport.com> --------- Co-authored-by: Zac Bergquist <zac.bergquist@goteleport.com> * Remove access-graph path resolution, proxy `/enterprise` requests (#46541) * Remove `access-graph` path from tsconfig * Proxy /enterprise requested in dev * update e ref (#46726) * fix: tolerate mismatched key PEM headers (#46725) * fix: tolerate mismatched key PEM headers Issue #43381 introduced a regression where we now fail to parse PKCS8 encoded RSA private keys within an "RSA PRIVATE KEY" PEM block in some cases. This format is somewhat non-standard, usually PKCS8 data should be in a "PRIVATE KEY" PEM block. However, certain versions of OpenSSL and possibly even Teleport in specific cases have generated private keys in this format. This commit updates ParsePrivateKey and ParsePublicKey to be more tolerant of PKCS8, PKCS1, or PKIX key data no matter which PEM header is used. Fixes #46710 changelog: fixed regression in private key parser to handle mismatched PEM headers * fix typo in comment Co-authored-by: Edoardo Spadolini <edoardo.spadolini@goteleport.com> --------- Co-authored-by: Edoardo Spadolini <edoardo.spadolini@goteleport.com> * Use dynamic base path for favicon images (#46719) * Add Datadog Incident Management plugin support (#46271) * Implement datadog plugin * Add unit tests * Add fallback recipient config * Rename to Datadog Incident Management * Update tests * Datadog Incident Management * Update tctl resource plugin command * Typos * Lint * Exclude api changes for now * Set channel size * Address feedback - Add PluginShutdownTimeout const - Support api endpoint configuration - Add additional godocs/comments * Comment about datadog client package * Document Datadog API types * Only post resolution message when the AR is resolved * Fix lint * Unused function --------- Co-authored-by: hugoShaka <hugo.hervieux@goteleport.com> * Add AutoUpdate Client/Cache implementation (#46661) * Add AutoUpdate Client/Cache implementation * CR changes * Add permission for proxy to access resources * Rename all occurrences auto update to camelcase * Remove auto update client wrapper * Drop AutoUpdateServiceClient helper Rename comments for consistency * User Tasks: services and clients implementation (#46131) This PR adds the implementation for the User Tasks: - services (backend+cache) - clients (API + tctl) - light validation to set up the path for later PRs * expanding testplan for host user creation (#46729) * Fix operator docs reference generator bug (#46732) In the reference page for one Kubernetes operator resource, some Markdown links are malformed. The issue is that some fields of custom resource definitions used by the operator consist of arrays of anonymous objects with fields that are also objects. When creating docs based on these fields, the operator resource docs generator creates a malformed link reference. This change modifies the generator to replace any spaces with hyphens before outputting link references, causing the resulting internal links to work correctly. This change also does some light refactoring to remove an unnecessary `switch` statement. * [auto] Update AMI IDs for 16.4.0 (#46746) Co-authored-by: GitHub <noreply@github.com> * Remove deprecated HTTP RemoteCluster endpoints (#46756) * Remove deprecated HTTP RemoteCluster endpoints * Remove redundant test * Add `tbot` helm chart to `version.mk` (#46763) * Remove LockConfiguration.LockName (#46772) Cleans up the deprecated config option now that gravitational/teleport.e#5034 has been merged. * adding a reference to to the host user guide (#46765) * Replace more Logrus usage with Slog (#46757) * Remove logrus from lib/auth/machineid * Switch authclient.Config.Log and TunnelAuthDialerConfig.Log to Slog * Add *slog.Logger to auth.Server * Remove logrus usage in `lib/auth/access.go` * Replace logrus with slog in lib/auth/accountrecovery.go * Replace logrus with slog in `lib/auth/apiserver.go` * Add missing logger to auth.Server * Fix test * Update AWS roles ARNs displayed on `tsh app login` for AWS console apps (#44983) * feat(tsh): list aws console logins from server * chore(services): remove unified resources change This is being covered on another PR. * test(tsh): solve TestAzure flakiness by waiting using app servers are ready * fix(tsh): apps with logins were fallingback into using aws arns * refactor(client): use GetEnrichedResources * chore(client): rename function * refactor(tsh): directly resource lisiting for apps and reuse cluster client * chore(client): reset client changes * refactor(tsh): reuse cluster client for fetching allowed logins * chore(tsh): remove unused function param * refactor(tsh): update getApp retry with login * refactor(tsh): use a single function to grab profile and cluste client * refactor(tsh): perform retry with login at caller site * fix(tsh): close auth client * test(tsh): fix test failing due to login misconfiguration * test(tsh): fix lint errors * test(tsh): remove unused imports * bulk audit event export api (#46399) * Reverting back to using the emitSessionJoin boolean * Nits and removing a debug log --------- Co-authored-by: Marco Dinis <marco.dinis@goteleport.com> Co-authored-by: Michael <michael.myers@goteleport.com> Co-authored-by: Paul Gottschling <paul.gottschling@goteleport.com> Co-authored-by: Rafał Cieślak <rafal.cieslak@goteleport.com> Co-authored-by: Nic Klaassen <nic@goteleport.com> Co-authored-by: Dan Johns <117299936+djohns7@users.noreply.github.com> Co-authored-by: Zac Bergquist <zac.bergquist@goteleport.com> Co-authored-by: Ryan Clark <ryan.clark@goteleport.com> Co-authored-by: Edoardo Spadolini <edoardo.spadolini@goteleport.com> Co-authored-by: Bernard Kim <bernard@goteleport.com> Co-authored-by: hugoShaka <hugo.hervieux@goteleport.com> Co-authored-by: Vadym Popov <vadym.popov@goteleport.com> Co-authored-by: Erik Tate <erik.tate@goteleport.com> Co-authored-by: teleport-post-release-automation[bot] <128860004+teleport-post-release-automation[bot]@users.noreply.github.com> Co-authored-by: GitHub <noreply@github.com> Co-authored-by: Noah Stride <noah.stride@goteleport.com> Co-authored-by: rosstimothy <39066650+rosstimothy@users.noreply.github.com> Co-authored-by: Gabriel Corado <gabriel.oliveira@goteleport.com> Co-authored-by: Forrest <30576607+fspmarshall@users.noreply.github.com>

) * Displaying mode and controls to additional participants * Moving SessionControlsInfoBroadcast over to kube/proxy * Transitioning to consistent proxy-emitted mode+controls * Moving message broadcast so new participant wont see it * Possible unit test fix (cant seem to test locally) * Fixed unit test * Adding a line break before messaging the participant * Linter errors * Emitting audit event and controls message for additional parties, i.e. not the session initiator * Revert "Emitting audit event and controls message for additional parties, i.e. not the session initiator" This reverts commit b66ad27. * Add User Tasks resource - protos (#46059) * Add User Integration Tasks resource - protos * add account id * move state to task instead of instance * rename from user integration task to user task * add instance id * Add notice to web UI that users arent equal to MAU (#46686) This adds a dismissible notice to the Users page for usage based billing users that notifies them that the user count here isn't an accurate reflection of MAU * Clarify TLS requirements in the Jira guide (#46484) Closes #45654 - Indicate that certificates for the Jira web server cannot be self signed. - Remove references to Caddy and a `Certificate` resource, which were left over from an attempted change to this guide that was not fully completed. * Remove TXT record validation of custom DNS zones in VNet (#46709) * Remove TXT record validation from custom DNS zones * Remove mentions of TXT records from docs * Outline in the RFD why domain verification was dropped * Update rfd/0163-vnet.md --------- * docs: mention the --days flag when executing an audit log query (#45764) * Update access-monitoring.mdx Include the default date range in the CLI example. This range is otherwise unclear and is hidden in the tctl audit help menu. * Update access-monitoring.mdx * Update docs/pages/admin-guides/access-controls/access-monitoring.mdx --------- * Remove access-graph path resolution, proxy `/enterprise` requests (#46541) * Remove `access-graph` path from tsconfig * Proxy /enterprise requested in dev * update e ref (#46726) * fix: tolerate mismatched key PEM headers (#46725) * fix: tolerate mismatched key PEM headers Issue #43381 introduced a regression where we now fail to parse PKCS8 encoded RSA private keys within an "RSA PRIVATE KEY" PEM block in some cases. This format is somewhat non-standard, usually PKCS8 data should be in a "PRIVATE KEY" PEM block. However, certain versions of OpenSSL and possibly even Teleport in specific cases have generated private keys in this format. This commit updates ParsePrivateKey and ParsePublicKey to be more tolerant of PKCS8, PKCS1, or PKIX key data no matter which PEM header is used. Fixes #46710 changelog: fixed regression in private key parser to handle mismatched PEM headers * fix typo in comment --------- * Use dynamic base path for favicon images (#46719) * Add Datadog Incident Management plugin support (#46271) * Implement datadog plugin * Add unit tests * Add fallback recipient config * Rename to Datadog Incident Management * Update tests * Datadog Incident Management * Update tctl resource plugin command * Typos * Lint * Exclude api changes for now * Set channel size * Address feedback - Add PluginShutdownTimeout const - Support api endpoint configuration - Add additional godocs/comments * Comment about datadog client package * Document Datadog API types * Only post resolution message when the AR is resolved * Fix lint * Unused function --------- * Add AutoUpdate Client/Cache implementation (#46661) * Add AutoUpdate Client/Cache implementation * CR changes * Add permission for proxy to access resources * Rename all occurrences auto update to camelcase * Remove auto update client wrapper * Drop AutoUpdateServiceClient helper Rename comments for consistency * User Tasks: services and clients implementation (#46131) This PR adds the implementation for the User Tasks: - services (backend+cache) - clients (API + tctl) - light validation to set up the path for later PRs * expanding testplan for host user creation (#46729) * Fix operator docs reference generator bug (#46732) In the reference page for one Kubernetes operator resource, some Markdown links are malformed. The issue is that some fields of custom resource definitions used by the operator consist of arrays of anonymous objects with fields that are also objects. When creating docs based on these fields, the operator resource docs generator creates a malformed link reference. This change modifies the generator to replace any spaces with hyphens before outputting link references, causing the resulting internal links to work correctly. This change also does some light refactoring to remove an unnecessary `switch` statement. * [auto] Update AMI IDs for 16.4.0 (#46746) * Remove deprecated HTTP RemoteCluster endpoints (#46756) * Remove deprecated HTTP RemoteCluster endpoints * Remove redundant test * Add `tbot` helm chart to `version.mk` (#46763) * Remove LockConfiguration.LockName (#46772) Cleans up the deprecated config option now that gravitational/teleport.e#5034 has been merged. * adding a reference to to the host user guide (#46765) * Replace more Logrus usage with Slog (#46757) * Remove logrus from lib/auth/machineid * Switch authclient.Config.Log and TunnelAuthDialerConfig.Log to Slog * Add *slog.Logger to auth.Server * Remove logrus usage in `lib/auth/access.go` * Replace logrus with slog in lib/auth/accountrecovery.go * Replace logrus with slog in `lib/auth/apiserver.go` * Add missing logger to auth.Server * Fix test * Update AWS roles ARNs displayed on `tsh app login` for AWS console apps (#44983) * feat(tsh): list aws console logins from server * chore(services): remove unified resources change This is being covered on another PR. * test(tsh): solve TestAzure flakiness by waiting using app servers are ready * fix(tsh): apps with logins were fallingback into using aws arns * refactor(client): use GetEnrichedResources * chore(client): rename function * refactor(tsh): directly resource lisiting for apps and reuse cluster client * chore(client): reset client changes * refactor(tsh): reuse cluster client for fetching allowed logins * chore(tsh): remove unused function param * refactor(tsh): update getApp retry with login * refactor(tsh): use a single function to grab profile and cluste client * refactor(tsh): perform retry with login at caller site * fix(tsh): close auth client * test(tsh): fix test failing due to login misconfiguration * test(tsh): fix lint errors * test(tsh): remove unused imports * bulk audit event export api (#46399) * Reverting back to using the emitSessionJoin boolean * Nits and removing a debug log --------- Co-authored-by: Marco Dinis <marco.dinis@goteleport.com> Co-authored-by: Michael <michael.myers@goteleport.com> Co-authored-by: Paul Gottschling <paul.gottschling@goteleport.com> Co-authored-by: Rafał Cieślak <rafal.cieslak@goteleport.com> Co-authored-by: Nic Klaassen <nic@goteleport.com> Co-authored-by: Dan Johns <117299936+djohns7@users.noreply.github.com> Co-authored-by: Zac Bergquist <zac.bergquist@goteleport.com> Co-authored-by: Ryan Clark <ryan.clark@goteleport.com> Co-authored-by: Edoardo Spadolini <edoardo.spadolini@goteleport.com> Co-authored-by: Bernard Kim <bernard@goteleport.com> Co-authored-by: hugoShaka <hugo.hervieux@goteleport.com> Co-authored-by: Vadym Popov <vadym.popov@goteleport.com> Co-authored-by: Erik Tate <erik.tate@goteleport.com> Co-authored-by: teleport-post-release-automation[bot] <128860004+teleport-post-release-automation[bot]@users.noreply.github.com> Co-authored-by: GitHub <noreply@github.com> Co-authored-by: Noah Stride <noah.stride@goteleport.com> Co-authored-by: rosstimothy <39066650+rosstimothy@users.noreply.github.com> Co-authored-by: Gabriel Corado <gabriel.oliveira@goteleport.com> Co-authored-by: Forrest <30576607+fspmarshall@users.noreply.github.com>

…ps (#44983) (#46806) * feat(tsh): list aws console logins from server * chore(services): remove unified resources change This is being covered on another PR. * test(tsh): solve TestAzure flakiness by waiting using app servers are ready * fix(tsh): apps with logins were fallingback into using aws arns * refactor(client): use GetEnrichedResources * chore(client): rename function * refactor(tsh): directly resource lisiting for apps and reuse cluster client * chore(client): reset client changes * refactor(tsh): reuse cluster client for fetching allowed logins * chore(tsh): remove unused function param * refactor(tsh): update getApp retry with login * refactor(tsh): use a single function to grab profile and cluste client * refactor(tsh): perform retry with login at caller site * fix(tsh): close auth client * test(tsh): fix test failing due to login misconfiguration * test(tsh): fix lint errors * test(tsh): remove unused imports

feat(tsh): list aws console logins from server

3b797d6

gabrielcorado requested review from greedy52 and rosstimothy August 1, 2024 20:15

github-actions bot added size/md tsh tsh - Teleport's command line tool for logging into nodes running Teleport. labels Aug 1, 2024

github-actions bot requested review from atburke and avatus August 1, 2024 20:16

chore(services): remove unified resources change

f912806

This is being covered on another PR.

greedy52 mentioned this pull request Aug 2, 2024

Fix AWS Console apps logins not being provided in all places #44992

Merged

greedy52 reviewed Aug 2, 2024

View reviewed changes

lib/client/api.go Outdated Show resolved Hide resolved

lib/client/api.go Outdated Show resolved Hide resolved

lib/client/api_test.go Outdated Show resolved Hide resolved

tool/tsh/common/app_aws.go Show resolved Hide resolved

tool/tsh/common/app.go Outdated Show resolved Hide resolved

gabrielcorado added 4 commits August 6, 2024 17:01

test(tsh): solve TestAzure flakiness by waiting using app servers are…

c2da0ec

… ready

fix(tsh): apps with logins were fallingback into using aws arns

ead8f87

refactor(client): use GetEnrichedResources

c5f1529

chore(client): rename function

3968afc

gabrielcorado requested a review from greedy52 August 6, 2024 20:32

rosstimothy reviewed Aug 7, 2024

View reviewed changes

lib/client/api.go Outdated Show resolved Hide resolved

tool/tsh/common/app.go Outdated Show resolved Hide resolved

gabrielcorado added 5 commits August 8, 2024 16:19

Merge branch 'master' into gabrielcorado/tsh-app-login-leaf-logins

64c358e

refactor(tsh): directly resource lisiting for apps and reuse cluster …

304fca0

…client

chore(client): reset client changes

1d00da7

refactor(tsh): reuse cluster client for fetching allowed logins

223494f

chore(tsh): remove unused function param

c6de8ac

gabrielcorado requested a review from rosstimothy August 9, 2024 00:43

rosstimothy reviewed Aug 9, 2024

View reviewed changes

tool/tsh/common/app.go Outdated Show resolved Hide resolved

tool/tsh/common/app.go Show resolved Hide resolved

refactor(tsh): update getApp retry with login

345c14d

greedy52 reviewed Aug 14, 2024

View reviewed changes

tool/tsh/common/app.go Outdated Show resolved Hide resolved

greedy52 reviewed Aug 14, 2024

View reviewed changes

gabrielcorado added 2 commits August 15, 2024 11:10

refactor(tsh): use a single function to grab profile and cluste client

da52380

Merge branch 'master' into gabrielcorado/tsh-app-login-leaf-logins

af717c8

Merge branch 'master' into gabrielcorado/tsh-app-login-leaf-logins

8843221

rosstimothy approved these changes Sep 9, 2024

View reviewed changes

public-teleport-github-review-bot bot removed request for avatus and atburke September 9, 2024 13:24

Merge branch 'master' into gabrielcorado/tsh-app-login-leaf-logins

efd8542

gabrielcorado added the backport/branch/v16 label Sep 9, 2024

gabrielcorado enabled auto-merge September 9, 2024 14:32

gabrielcorado added 3 commits September 9, 2024 13:45

test(tsh): fix lint errors

2740ab8

Merge branch 'gabrielcorado/tsh-app-login-leaf-logins' of github.com:…

c5ad14c

…gravitational/teleport into gabrielcorado/tsh-app-login-leaf-logins

test(tsh): remove unused imports

954e8cf

Merge branch 'master' into gabrielcorado/tsh-app-login-leaf-logins

8136cfa

gabrielcorado added this pull request to the merge queue Sep 19, 2024

Merged via the queue into master with commit f75e8fc Sep 19, 2024
39 checks passed

gabrielcorado deleted the gabrielcorado/tsh-app-login-leaf-logins branch September 19, 2024 19:14

gabrielcorado mentioned this pull request Sep 20, 2024

[v16] Update AWS roles ARNs displayed on tsh app login for AWS console apps #46806

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update AWS roles ARNs displayed on `tsh app login` for AWS console apps #44983

Update AWS roles ARNs displayed on `tsh app login` for AWS console apps #44983

gabrielcorado commented Aug 1, 2024 •

edited

Loading

github-actions bot commented Aug 1, 2024

greedy52 left a comment

gabrielcorado commented Aug 9, 2024

greedy52 Aug 14, 2024

gabrielcorado commented Aug 30, 2024

rosstimothy commented Sep 1, 2024

gabrielcorado commented Sep 2, 2024

rosstimothy commented Sep 4, 2024

rosstimothy commented Sep 19, 2024

public-teleport-github-review-bot bot commented Sep 19, 2024

Update AWS roles ARNs displayed on tsh app login for AWS console apps #44983

Update AWS roles ARNs displayed on tsh app login for AWS console apps #44983

Conversation

gabrielcorado commented Aug 1, 2024 • edited Loading

github-actions bot commented Aug 1, 2024

greedy52 left a comment

Choose a reason for hiding this comment

gabrielcorado commented Aug 9, 2024

greedy52 Aug 14, 2024

Choose a reason for hiding this comment

gabrielcorado commented Aug 30, 2024

rosstimothy commented Sep 1, 2024

gabrielcorado commented Sep 2, 2024

rosstimothy commented Sep 4, 2024

rosstimothy commented Sep 19, 2024

public-teleport-github-review-bot bot commented Sep 19, 2024

Update AWS roles ARNs displayed on `tsh app login` for AWS console apps #44983

Update AWS roles ARNs displayed on `tsh app login` for AWS console apps #44983

gabrielcorado commented Aug 1, 2024 •

edited

Loading