Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v14] Introduce a dedicated backend key type #45713

Merged
merged 1 commit into from
Aug 28, 2024
Merged

[v14] Introduce a dedicated backend key type #45713

merged 1 commit into from
Aug 28, 2024

Conversation

rosstimothy
Copy link
Contributor

Backport #45706 to branch/v14

@rosstimothy rosstimothy added the no-changelog Indicates that a PR does not require a changelog entry label Aug 22, 2024
@rosstimothy
Introduce a dedicated backend key type (#45706)
b5a7b05 
For the moment the type is nothing more than an alias for []byte.
This will allow for transitioning enterprise to use the new type
without breaking the builds. Once enterprise is updated and all
assumptions about a Key being a []byte are removed the alias will
be dropped in favor of making a Key its own type.
@rosstimothy rosstimothy marked this pull request as ready for review August 23, 2024 13:06
@rosstimothy rosstimothy added this pull request to the merge queue Aug 28, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 28, 2024
@rosstimothy rosstimothy added this pull request to the merge queue Aug 28, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 28, 2024
@rosstimothy rosstimothy added this pull request to the merge queue Aug 28, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 28, 2024
@rosstimothy rosstimothy added this pull request to the merge queue Aug 28, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 28, 2024
@rosstimothy rosstimothy added this pull request to the merge queue Aug 28, 2024
Merged via the queue into branch/v14 with commit 0c448a7 Aug 28, 2024
26 checks passed
@rosstimothy rosstimothy deleted the tross/backport-45706/v14 branch August 28, 2024 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcoandredinis marcoandredinis marcoandredinis approved these changes

@fspmarshall fspmarshall fspmarshall approved these changes

Assignees
No one assigned
Labels
backport no-changelog Indicates that a PR does not require a changelog entry size/sm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rosstimothy @marcoandredinis @fspmarshall