Add more context around _labels role fields
#46401
Merged
+10
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #10463 We already mention the `cluster_labels` role field in the role reference, but it could be more explicit that this field deals with Trusted Clusters. This change adds a short table to the role reference to indicate the Teleport resources that correspond to different label fields.
ptgott
added
no-changelog
github-actions
bot
requested review from
mmcallister,
r0mant,
xinding33 and
zmb3
|
🤖 Vercel preview here: https://docs-ezbjt1hu6-goteleport.vercel.app/docs/ver/preview |
zmb3
approved these changes
Sep 9, 2024
mmcallister
approved these changes
Sep 9, 2024
public-teleport-github-review-bot
bot
removed request for
r0mant and
xinding33
This was referenced Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10463
We already mention the
cluster_labelsrole field in the role reference, but it could be more explicit that this field deals with Trusted Clusters. This change adds a short table to the role reference to indicate the Teleport resources that correspond to different label fields.