[v14] Fix Firestore backend keys #46435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosstimothy
changed the title
The firestorebk.record field inadvertently was changed from a []byte to a backend.Key. This prevents any existing data which already existed in firestore from being retrieved. This reverts the record key back to []byte and adds a conversion mechanism to allow _all_ data which may have been persisted in either format to be retrieved. Fixes #46386
rosstimothy
force-pushed
the
tross/backport-46406/v14
branch
from
5c8aa2b
to
ca5ce65
Compare
fspmarshall
approved these changes
Sep 10, 2024
tigrato
approved these changes
Sep 10, 2024
public-teleport-github-review-bot
bot
removed the request for review
from GavinFrazar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #46406 to branch/v14
changelog: Fixed an issue that prevented the Firestore backend from reading existing data.