[v14] Update generic storage service to support validation and custom keys #46453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosstimothy
added
backport
no-changelog
rosstimothy
changed the title
rosstimothy
force-pushed
the
tross/backport-46319/v14
branch
from
c98c20f
to
51f7219
Compare
…46319) Adds two new optional configuration options to the generic.Service: ValidateFunc and KeyFunc. ValidateFunc is a custom function that is called prior to persisting a resource in the backend. If the function returns an error, the resource is not stored and the error is returned to users. KeyFunc is a custom function used to derive the key for a particular resource. By default the generic service uses the metadata name as the key, however, in some scenarios more control over the key might be desired. For instance, a singleton resource might want to enforce that the key is also a static value instead of something that a user may supply.
rosstimothy
force-pushed
the
tross/backport-46319/v14
branch
from
51f7219
to
01635a1
Compare
vapopov
approved these changes
Sep 10, 2024
probakowski
approved these changes
Sep 10, 2024
public-teleport-github-review-bot
bot
removed the request for review
from gzdunek
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #46319 to branch/v14