[v15] Document AWS Tags used when using the AWS OIDC Integration #46643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcoandredinis
added
the
no-changelog
marcoandredinis
temporarily deployed
to
vercel
GitHub Actions
Inactive
r0mant
approved these changes
Sep 16, 2024
|
🤖 Vercel preview here: https://docs-oeymwnwy3-goteleport.vercel.app/docs/ver/preview |
kimlisa
reviewed
Sep 17, 2024
| @@ -147,6 +152,28 @@ export function AwsOidc() { | |||
| AWS RDS | |||
| </RouteLink>{' '} | |||
| instances during resource enrollment. | |||
| <P> | |||
There was a problem hiding this comment.
i'm not sure how the ui tests are passing, but can we change this to how i done it here (for your v16 too 🙏 ): #46700
(it should fix the lint issue, i don't think we backported that specific component)
When the AWS OIDC Integration creates an AWS Resource it adds a couple of tags. Those can be used to group resources in AWS. Even tho Teleport was doing it, it was not documented. This PR adds the documentation to this, in both the Docs and Discover flows.
marcoandredinis
force-pushed
the
bot/backport-46632-branch/v15
branch
from
dcb1136
to
e8dff85
Compare
marcoandredinis
temporarily deployed
to
vercel
GitHub Actions
Inactive
kimlisa
approved these changes
Sep 18, 2024
public-teleport-github-review-bot
bot
removed the request for review
from zmb3
|
🤖 Vercel preview here: https://docs-1n4ip0a03-goteleport.vercel.app/docs/ver/preview |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #46632 to branch/v15