Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: SSO MFA - support for SAML ForceAuthn for login and mfa checks #46703

Merged
merged 5 commits into from
Oct 7, 2024
Merged

feat: SSO MFA - support for SAML ForceAuthn for login and mfa checks #46703

merged 5 commits into from
Oct 7, 2024

Conversation

Joerger
Copy link
Contributor

@Joerger Joerger commented Sep 18, 2024 •
edited
Loading

Part of the implementation of SSO MFA

Depends on #46687

Updates #30844

@Joerger Joerger added the no-changelog Indicates that a PR does not require a changelog entry label Sep 18, 2024
@Joerger Joerger mentioned this pull request Sep 18, 2024
Open
@Joerger Joerger force-pushed the joerger/auth-connector-mfa-settings branch from f4f51dc to 3cf210a Compare September 21, 2024 00:24
@Joerger Joerger force-pushed the joerger/auth-connector-mfa-settings branch from 3cf210a to 798c5e3 Compare September 30, 2024 17:10
Base automatically changed from joerger/auth-connector-mfa-settings to master September 30, 2024 19:51
@Joerger Joerger marked this pull request as ready for review October 1, 2024 00:09
@Joerger
Copy link
Contributor Author

Joerger commented Oct 2, 2024

@GavinFrazar @r0mant Friendly ping for review, would be good to get this config change into v17

rosstimothy
rosstimothy approved these changes Oct 7, 2024
View reviewed changes
Copy link
Contributor

@rosstimothy rosstimothy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though, can we add some test coverage that validates each option does the appropriate thing when YES/NO/UNSPECIFIED is set?

@public-teleport-github-review-bot public-teleport-github-review-bot bot removed the request for review from r0mant October 7, 2024 13:30
@Joerger Joerger enabled auto-merge October 7, 2024 17:05
@Joerger Joerger added this pull request to the merge queue Oct 7, 2024
Merged via the queue into master with commit de6d19b Oct 7, 2024
41 of 42 checks passed
@Joerger Joerger deleted the joerger/saml-force-auth branch October 7, 2024 18:11
@Joerger Joerger mentioned this pull request Oct 7, 2024
Merged
@hugoShaka hugoShaka mentioned this pull request Oct 8, 2024
Merged
@Joerger Joerger mentioned this pull request Oct 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rosstimothy rosstimothy rosstimothy approved these changes

@GavinFrazar GavinFrazar GavinFrazar approved these changes

Assignees
No one assigned
Labels
no-changelog Indicates that a PR does not require a changelog entry size/sm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Joerger @GavinFrazar @rosstimothy