[v14] move acs_url input validation to rpc create and update methods #46847
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
local
package to RPC create and update methods inauth
package. Performing such strict validation in thelocal
methods breaks cache writes in a cluster that may already have service provider configured with unsupported values.local
package still calls the validation functions but only logs a warning on error.FilterSAMLEntityDescriptor
is slightly updated to return error if at least one ACS value is filtered. Previously, it would return error only if all the provided ACS value were filtered.Backport of #46833 to Branch/v14.
v14
does not support relay state params so validation for that field remains unchanged.changelog: Fixed a regression in the SAML IdP service which prevented cache from initializing in a cluster that may have a service provider configured with unsupported
acs_url
andrelay_state
values.