Teleport sends AWS metadata to access graph #46970
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tigrato
reviewed
Oct 1, 2024
| @@ -65,7 +65,7 @@ func (s *Server) reconcileAccessGraph(ctx context.Context, currentTAGResources * | |||
| // We will send a delete request for all resources and return. | |||
| upsert, toDel := aws_sync.ReconcileResults(currentTAGResources, &aws_sync.Resources{}) | |||
|
|
|||
| if err := push(stream, upsert, toDel); err != nil { | |||
| if err := push(stream, upsert, toDel, []*accessgraphv1alpha.AWSMetadata{}); err != nil { | |||
There was a problem hiding this comment.
just add aws metadata to the resources and let reconciler decidde when we need to push/delete/not push anything
|
Closing after chatting with @jakule about an API-only solution, where the UI can pull the account ID+alias and annotate graph objects accordingly. More info in the Slack discussion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/gravitational/access-graph/issues/979 specifies a need for friendly AWS account names in access graph resources. These changes add an
AccountAliasfield toAccessGraphAWSSyncfor creating a new discovery configuration/webapi/sites/:site/discoveryconfig. This account alias is then emitted as metadata to the access graph alongside its corresponding AWS resources. A subsequent PR will modify the access graph to store this metadata in anaccount_id -> account_aliaslookup table, and include account alias on selected AWS resources.