Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add filesystem lock for unix and windows platforms #46981

Merged
merged 3 commits into from
Oct 4, 2024

Conversation

vapopov
Copy link
Contributor

@vapopov vapopov commented Sep 30, 2024

In this PR added utility for acquiring the filesystem lock to be able wait for another process until this lock is released.
This functionality related to Client tools autoupdate #46587

@zmb3
Copy link
Collaborator

zmb3 commented Sep 30, 2024

What happens to utils.FSTryWriteLock? Should we remove that code and replace it with this new code?

lib/utils/flock/flock.go Outdated Show resolved Hide resolved
lib/utils/flock/flock.go Outdated Show resolved Hide resolved
lib/utils/flock/flock.go Outdated Show resolved Hide resolved
@vapopov vapopov force-pushed the vapopov/updater-directory-lock branch from 1a7ecc0 to 6de91b4 Compare September 30, 2024 18:47
@vapopov vapopov requested a review from zmb3 September 30, 2024 20:24
@vapopov vapopov enabled auto-merge October 1, 2024 16:53
@vapopov
Copy link
Contributor Author

vapopov commented Oct 3, 2024

@zmb3 @smallinsky @Tener could you please review this PR, need one more approval to merge

@vapopov vapopov added this pull request to the merge queue Oct 4, 2024
Merged via the queue into master with commit f11cfb9 Oct 4, 2024
39 checks passed
@vapopov vapopov deleted the vapopov/updater-directory-lock branch October 4, 2024 10:29
@public-teleport-github-review-bot

@vapopov See the table below for backport results.

Branch Result
branch/v14 Create PR
branch/v15 Create PR
branch/v16 Create PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants