display all security group rules for a port range #47009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GavinFrazar
added
discover
|
oh, realized that I need to fix the |
GavinFrazar
force-pushed
the
gavinfrazar/display-all-security-group-rules-per-port
branch
from
1145dc5
to
7cad307
Compare
GavinFrazar
commented
Oct 1, 2024
GavinFrazar
force-pushed
the
gavinfrazar/display-all-security-group-rules-per-port
branch
from
7cad307
to
cfc73cc
Compare
GavinFrazar
force-pushed
the
gavinfrazar/display-all-security-group-rules-per-port
branch
from
cfc73cc
to
ba41382
Compare
avatus
approved these changes
Oct 1, 2024
kimlisa
approved these changes
Oct 1, 2024
web/packages/teleport/src/Discover/Database/EnrollRdsDatabase/SingleEnrollment.tsx
Show resolved
Hide resolved
public-teleport-github-review-bot
bot
removed request for
kiosion and
ravicious
GavinFrazar
deleted the
gavinfrazar/display-all-security-group-rules-per-port
branch
|
@GavinFrazar See the table below for backport results.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Fixed a bug where only one IP CIDR block security group rule for a port range was displayed in the web UI RDS enrollment wizard when viewing a security group.
Part of:
This fixes the web ui to display all of the rules for each port range.
There's another part to that issue that requires a change in the backend code so that we render security group reference rules, but that's for another PR.
UI Diff
I have an aws security group that has two rules, both of which allow inbound access from an IP address on postgres port 5432.
Before
After