Reduce log spam generated by conflicting session_id and event_index #48548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosstimothy
added
backport/branch/v14
no-changelog
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
|
@greedy52 @gabrielcorado I only implemented the log suppression advice from #46801 and am not marking this as fixing said issue, unless you think this will suffice and there is nothing more to do. |
rosstimothy
commented
Nov 6, 2024
codingllama
approved these changes
Nov 6, 2024
rosstimothy
force-pushed
the
tross/dynamo_conflict_logs
branch
from
e40c69e
to
9e4f1d9
Compare
codingllama
approved these changes
Nov 7, 2024
public-teleport-github-review-bot
bot
removed request for
vapopov and
greedy52
|
@rosstimothy See the table below for backport results.
|
rosstimothy
added a commit
that referenced
this pull request
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alters the log messages from #40854 such that they only occur if the fallback mechanism fails.
Updates #46801