Update several admin actions to allow reusable MFA challenges #49095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Joerger
added
the
no-changelog
Joerger
force-pushed
the
joerger/update-endpoints-to-allow-reused-mfa
branch
from
441ccae
to
4cb8ac4
Compare
tigrato
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update several admin action endpoints to allow reusable MFA challenges, as well as add clarification in the comments and RFD about reusable MFA challenges for admin actions.
In general, we should default to allowing reuse server side but only utilizing reuse client side when it is necessary. This should result in fewer compatibility concerns between versions.
This should also unblock #46891 by enabling reuse for all of the endpoints hit by
tctl create -f multiple-resources.yaml.