[teleport-update] Move teleport binaries to new path {deb,rpm} #49110
Conversation
vapopov
added
the
no-changelog
| set -eu | ||
|
|
||
| case "$1" in | ||
| configure) |
There was a problem hiding this comment.
We can use teleport-update link to accomplish this instead. It will create links from /usr/local/teleport-system/bin to /usr/local/bin without overriding auto-update-managed links.
| NEW_PATH="$NEW_BASE_DIR/$BASENAME" | ||
|
|
||
| if [ -e "$FILE" ] && [ ! -L "$FILE" ]; then | ||
| echo "Removing old binary at $FILE..." |
There was a problem hiding this comment.
Curious why we'd want to remove binaries here? teleport-update link will fail in this case. Should we change that behavior?
| echo "Removing symlinks from old paths..." | ||
|
|
||
| for FILE in "${OLD_PATHS[@]}"; do | ||
| if [ -L "$FILE" ]; then |
There was a problem hiding this comment.
This will remove updater-managed symlinks when the package is removed. We only want to remove symlinks into /usr/local/teleport-system. I think we should add a teleport-update unlink command for this.
|
|
||
| echo "Post-upgrade cleanup and symlink creation completed." | ||
| ;; | ||
| remove|deconfigure) |
There was a problem hiding this comment.
Should we run this on deconfigure, or just remove? Seems like we'd want these symlinks to stay around until the package is fully removed.
In this PR teleport binaries moved to new location according:
https://github.com/gravitational/teleport/blob/master/rfd/0184-agent-auto-updates.md?plain=1#L1774-L1780
Related: https://github.com/gravitational/cloud/issues/10289