Refresh resources after dropping an access request #49125
+325
−80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ravicious
reviewed
Nov 18, 2024
| const requestResourcesRefresh = useCallback( | ||
| () => emitterRef.current.emit('refresh'), | ||
| (rootClusterUri: RootClusterUri) => |
There was a problem hiding this comment.
What do you think about making the hook accept the rootClusterUri argument? Then the caller doesn't need to remember to pass it to every function that the hook provides.
avatus
approved these changes
Nov 18, 2024
| ctx.clustersService.dropRoles(rootClusterUri, [assumedRequest.id]) | ||
| ); | ||
| requestResourcesRefresh(rootClusterUri); | ||
| } catch (err) { | ||
| ctx.notificationsService.notifyError({ | ||
| title: 'Could not switch back the role', |
There was a problem hiding this comment.
i know this error text was already present but it seems so weird. I think it'd be better saying something like "Could not drop role" or "Could not switch back to default role" or something. Don't have to change here, just discussing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #42381
As mentioned in the linked issue, we were unable to refresh resources after dropping an access request because
ResourcesContextwas lower in the component tree, so we simply couldn't access it.A simple fix for this problem is to move it higher in the tree and add a root cluster URI as an argument to its functions, so we can still refresh resources within a single workspace.
Changelog: Teleport Connect now refreshes the resources view after dropping an access request