Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

interactive script updates #2038

Merged
merged 9 commits into from
Feb 20, 2023
Merged

interactive script updates #2038

merged 9 commits into from
Feb 20, 2023

Conversation

afeiszli
Copy link
Contributor

No description provided.

@afeiszli afeiszli marked this pull request as draft February 14, 2023 21:47
@afeiszli afeiszli changed the title saving work interactive script updates Feb 14, 2023
@afeiszli afeiszli marked this pull request as ready for review February 17, 2023 04:31
@afeiszli
Copy link
Contributor Author

  1. renamed nm-quick-interactive to nm-quick for brevity
  2. updated README
  3. updated docker-compose files to use placeholder image tags
  4. updated nm-quick to allow deploying specified version tag
  5. updated nm-quick to allow deploying specified branch by building locally

nm-quick has the following usage:

alex@zorg:~/netmaker$ sudo scripts/nm-quick.sh -v
usage: ./nm-quick.sh [-e] [-b buildtype] [-t tag]
  -e      if specified, will install netmaker EE
  -b      type of build; options:
          "version" - will install a specific version of Netmaker using remote git and dockerhub
          "local": - will install by cloning repo and and building images from git
          "branch": - will install a specific branch using remote git and dockerhub 
  -t      tag of build; if buildtype=version, tag=version. If builtype=branch or builtype=local, tag=branch
examples:
          nm-quick.sh -e -b version -t v0.18.0
          nm-quick.sh -e -b local -t feature_v0.17.2_newfeature
          nm-quick.sh -e -b branch -t develop

Test Steps:

  1. Run nm-quick without arguments.
  2. Should install 0.18.0 as normal
  3. Install a branch using nm-quick with the following arguments: ./nm-quick -b local -t story/GRA-1167-2
  4. Should install from branch, building docker from cloned git repo. NOTE: will currently only work against story/GRA-1167-2, since it requires the updated docker-compose files with placeholder image tags.

@afeiszli
Copy link
Contributor Author

@theguy951357 retest

Copy link
Contributor

@theguy951357 theguy951357 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

script builds a working server

script with tags builds a server from that branch.

pass

@0xdcarns 0xdcarns merged commit dd2f99b into develop Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants