Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gra 1242 fix pull #2059

Merged
merged 7 commits into from
Feb 21, 2023
Merged

Gra 1242 fix pull #2059

merged 7 commits into from
Feb 21, 2023

Conversation

0xdcarns
Copy link
Contributor

@0xdcarns 0xdcarns commented Feb 21, 2023

Describe your changes

  • Adapted Pull to new Node and consolidated peer update logic on pull

Provide Issue ticket number if applicable/not in title

Provide testing steps

  • Check that pull works on client when connected to peers

Checklist before requesting a review

  • My changes affect only 10 files or less.
  • I have performed a self-review of my code and tested it.
  • If it is a new feature, I have added thorough tests, my code is <= 1450 lines.
  • If it is a bugfix, my code is <= 200 lines.
  • My functions are <= 80 lines.
  • I have had my code reviewed by a peer.
  • My unit tests pass locally.
  • Netmaker is awesome.

Copy link
Contributor

@theguy951357 theguy951357 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

root@ubuntuQA:# netclient pull office
root@ubuntuQA:
# bash roundofpings.sh
This script needs nmap to run to find egress ranges. make sure it is installed
10.114.63.4 IS UP
e5fd:4206:9753:2021::4 IS UP
10.114.63.3 IS UP
e5fd:4206:9753:2021::3 IS UP
10.114.63.2 IS UP
e5fd:4206:9753:2021::2 IS UP
root@ubuntuQA:~# netclient list
[
{
"network": "office",
"node_id": "73a81c7b-003c-41c2-8264-dee4bb07ad02",
"connected": true,
"ipv4_addr": "10.114.63.1/24",
"ipv6_addr": "e5fd:4206:9753:2021::1/64"
}
]

netclient list works after a pull. connections still strong after a pull.
pass

@0xdcarns 0xdcarns merged commit ce04cfc into develop Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants