Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GRA-1395: added host port check on migrate #2138

Merged
merged 1 commit into from
Mar 22, 2023
Merged

GRA-1395: added host port check on migrate #2138

merged 1 commit into from
Mar 22, 2023

Conversation

0xdcarns
Copy link
Contributor

@0xdcarns 0xdcarns commented Mar 22, 2023 •
edited
Loading

Describe your changes

  • Added port check on migrate

Provide Issue ticket number if applicable/not in title

title.

Provide testing steps

  • ensure hosts have ports set on migrations

Checklist before requesting a review

  • My changes affect only 10 files or less.
  • I have performed a self-review of my code and tested it.
  • If it is a new feature, I have added thorough tests, my code is <= 1450 lines.
  • If it is a bugfix, my code is <= 200 lines.
  • My functions are <= 80 lines.
  • I have had my code reviewed by a peer.
  • My unit tests pass locally.
  • Netmaker is awesome.

theguy951357
theguy951357 approved these changes Mar 22, 2023
View reviewed changes
Copy link
Contributor

@theguy951357 theguy951357 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

listening port migrates given that dynamic port is set to off on 0.17.1 before migration.
critical list 100%

@0xdcarns 0xdcarns merged commit 443f0b0 into develop Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattkasun mattkasun mattkasun approved these changes

@theguy951357 theguy951357 theguy951357 approved these changes

@Aceix Aceix Awaiting requested review from Aceix

@alphadose alphadose Awaiting requested review from alphadose

@afeiszli afeiszli Awaiting requested review from afeiszli

@abhishek9686 abhishek9686 Awaiting requested review from abhishek9686

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@0xdcarns @theguy951357 @mattkasun