Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Story/gra 1431 #2141

Merged
merged 3 commits into from
Mar 22, 2023
Merged

Story/gra 1431 #2141

merged 3 commits into from
Mar 22, 2023

Conversation

afeiszli
Copy link
Contributor

@afeiszli afeiszli commented Mar 22, 2023

Describe your changesRu

Modified nm-quick.sh and nm-upgrade.sh to use the registration key, instead of the access key.

Provide Issue ticket number if applicable/not in title

GRA-1431

Provide testing steps

  1. Run nm-quick.sh on a fresh ubuntu server and install netmaker
  2. Confirm install is successful
  3. Wipe server, including any remnants of netclient
  4. Run nm-quick-interactive.sh for 0.17.1
  5. Add some networks and nodes
  6. Run nm-upgrade.sh
  7. Confirm that server is upgraded properly, running, and that there is a "default host" in all networks for netmaker-1

Checklist before requesting a review

  • My changes affect only 10 files or less.
  • I have performed a self-review of my code and tested it.
  • If it is a new feature, I have added thorough tests, my code is <= 1450 lines.
  • If it is a bugfix, my code is <= 200 lines.
  • My functions are <= 80 lines.
  • I have had my code reviewed by a peer.
  • My unit tests pass locally.
  • Netmaker is awesome.

Copy link
Contributor

@theguy951357 theguy951357 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nm-quick and nm-upgrade use a registration key to join the default node to a network.
critical list 100%

@0xdcarns 0xdcarns merged commit b1b4fb8 into develop Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants