Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GRA-1339: host pull #2142

Merged
merged 1 commit into from
Mar 24, 2023
Merged

GRA-1339: host pull #2142

merged 1 commit into from
Mar 24, 2023

Conversation

0xdcarns
Copy link
Contributor

@0xdcarns 0xdcarns commented Mar 22, 2023 •
edited by theguy951357
Loading

Describe your changes

  • Adjusted pull system to get all peers + server conf

Provide Issue ticket number if applicable/not in title

title.

Provide testing steps

  • join 2 hosts to server(s)
  • call pull netclient pull
  • ensure you get a good response
  • ensure peers are correct
  • ensure server.yml looks fine

Checklist before requesting a review

  • My changes affect only 10 files or less.
  • I have performed a self-review of my code and tested it.
  • If it is a new feature, I have added thorough tests, my code is <= 1450 lines.
  • If it is a bugfix, my code is <= 200 lines.
  • My functions are <= 80 lines.
  • I have had my code reviewed by a peer.
  • My unit tests pass locally.
  • Netmaker is awesome.

@0xdcarns 0xdcarns force-pushed the GRA-1339/host-pull branch from 5664bf3 to 63eac1e Compare March 22, 2023 19:37
@0xdcarns 0xdcarns mentioned this pull request Mar 22, 2023
Merged
9 tasks
theguy951357
theguy951357 approved these changes Mar 24, 2023
View reviewed changes
Copy link
Contributor

@theguy951357 theguy951357 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pr steps pass
critical list 100%
this fixes the pull issue on GRA-1435

@afeiszli afeiszli merged commit d41a105 into develop Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhishek9686 abhishek9686 abhishek9686 approved these changes

@afeiszli afeiszli afeiszli approved these changes

@theguy951357 theguy951357 theguy951357 approved these changes

@Aceix Aceix Awaiting requested review from Aceix

@alphadose alphadose Awaiting requested review from alphadose

@mattkasun mattkasun Awaiting requested review from mattkasun

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@0xdcarns @theguy951357 @afeiszli @abhishek9686