Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gra 1459 extclient #2148

Merged
merged 2 commits into from
Mar 29, 2023
Merged

Gra 1459 extclient #2148

merged 2 commits into from
Mar 29, 2023

Conversation

mattkasun
Copy link
Contributor

@mattkasun mattkasun commented Mar 28, 2023

Describe your changes

fixes #2125

Provide Issue ticket number if applicable/not in title

Provide testing steps

see GRA-1459

Checklist before requesting a review

  • My changes affect only 10 files or less.
  • I have performed a self-review of my code and tested it.
  • If it is a new feature, I have added thorough tests, my code is <= 1450 lines.
  • If it is a bugfix, my code is <= 200 lines.
  • My functions are <= 80 lines.
  • I have had my code reviewed by a peer.
  • My unit tests pass locally.
  • Netmaker is awesome.

regenerate wg keys
@CLAassistant
Copy link

CLAassistant commented Mar 28, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@theguy951357 theguy951357 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changing the name of an ext client does not reset private key field to placeholder text.

@afeiszli afeiszli merged commit cdf0738 into develop Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Renaming an external client causes the private key to be replaced with [ENTER PRIVATE KEY]
4 participants