[NET-404] Run in limited mode when ee checks fail #2474

gabrielseibel1 · 2023-07-28T12:18:45Z

Describe your changes

Netmaker server should block continuing startup, rather than logging fatal, if license checker fails
Netmaker server should have a single API for status that the server can reach in this scenario
Netmaker should return licensing status

Provide testing steps

Try to run an EE server with licensing problems (could be just not setting the env vars correctly)
See that the server responds with {"db_connected":...,"broker_connected":...,"unlicensed_ee":true} to GETting /api/server/status

Checklist before requesting a review

My changes affect only 10 files or less.
I have performed a self-review of my code and tested it.
If it is a new feature, I have added thorough tests, my code is <= 1450 lines.
If it is a bugfix, my code is <= 200 lines.
My functions are <= 80 lines.
I have had my code reviewed by a peer.
My unit tests pass locally.
Netmaker is awesome.

abhishek9686 · 2023-07-28T12:49:27Z

suggested changes to add the Api limiting mode to middleware

This reverts commit 069c219.

This reverts commit 59dbab8.

This reverts commit e2f1f28.

…ed state" This reverts commit 58cfbba.

This reverts commit 77c6dbd.

ee/ee_controllers/middleware.go

Aceix

staticcheck is failing

abhishek9686 · 2023-08-01T15:19:30Z

staticcheck is failing

unused func https://github.com/gravitl/netmaker/blob/ec6f6dbb7fa04ffaf8fb663409ec52262792c57e/ee/license.go#L178C1-L179C2

theguy951357

tested and passed

* Add limited http handlers functionality to rest handler * Export ee.errValidation (ee.ErrValidation) * Export a fatal error handled by the hook manager * Export a new status variable for unlicensed server * Mark server as unlicensed when ee checks fail * Handle license validation failures with a (re)boot in a limited state * Revert "Export a fatal error handled by the hook manager" This reverts commit 069c219. * Revert "Export ee.errValidation (ee.ErrValidation)" This reverts commit 59dbab8. * Revert "Add limited http handlers functionality to rest handler" This reverts commit e2f1f28. * Revert "Handle license validation failures with a (re)boot in a limited state" This reverts commit 58cfbba. * Revert "Mark server as unlicensed when ee checks fail" This reverts commit 77c6dbd. * Handle license validation failures with a middleware * Forbid responses if unlicensed ee and not in status api * Remove unused func

* create gateways during migration * set version for testing * restruct migration * debug logging * enforce unique names for ext client names (#2476) * enforce unique names for ext client names * only check for unique id on creation * check for unique id if changed * prune(NET-483): remove defunct host.internetgateway field (#2487) * don't reference host on err (#2493) * deprecrate netclient install scripts (#2490) * Net 500: validate network parameter passed to node endpoints (#2480) * enforce unique names for ext client names * only check for unique id on creation * check for unique id if changed * validate network parameter passed to node endpoints --------- Co-authored-by: Abhishek K <32607604+abhishek9686@users.noreply.github.com> * NET-513 (#2492) nm-certs.sh now requests certificate for EE and CE edition domains accordingly. * [NET-404] Run in limited mode when ee checks fail (#2474) * Add limited http handlers functionality to rest handler * Export ee.errValidation (ee.ErrValidation) * Export a fatal error handled by the hook manager * Export a new status variable for unlicensed server * Mark server as unlicensed when ee checks fail * Handle license validation failures with a (re)boot in a limited state * Revert "Export a fatal error handled by the hook manager" This reverts commit 069c219. * Revert "Export ee.errValidation (ee.ErrValidation)" This reverts commit 59dbab8. * Revert "Add limited http handlers functionality to rest handler" This reverts commit e2f1f28. * Revert "Handle license validation failures with a (re)boot in a limited state" This reverts commit 58cfbba. * Revert "Mark server as unlicensed when ee checks fail" This reverts commit 77c6dbd. * Handle license validation failures with a middleware * Forbid responses if unlicensed ee and not in status api * Remove unused func * feat(NET-449): add sync feature to request a host pull from server (#2491) * fix(NET-486): change client name length validation (#2498) set limit to 5<=x<=32 * [NET-477] Pick AMB URL dynamically (#2489) * Introduce config for environment * Introduce func to get environment * Choose accounts api host from environment * Test the ee package on workflows * Use build tag ee for license_test.go * [Feature]: nm-quick script tackling arm TODO support (#2488) * domain flag for auto installs * use static servers with custom domain (#2421) * send delete peer update always * fix add/remove host api calls * keep mq updates in a single go func * move branch test logic to devops (#2443) * handle IOT OS * save server name to env (#2460) * ensure branch test servers available after test runs (#2467) * save server name to env * free server always; add PR to discord messages * use correct method to delete droplets (#2468) * quick fix for the launcher * removed exit when triggering not supported exit and removed the TODO comments related to this issue --------- Co-authored-by: Matthew R Kasun <mkasun@nusak.ca> Co-authored-by: Alex Feiszli <31018251+afeiszli@users.noreply.github.com> Co-authored-by: Christopher Blaha <crispspiceguitar@gmail.com> Co-authored-by: Abhishek Kondur <abhi281342@gmail.com> Co-authored-by: Abhishek K <32607604+abhishek9686@users.noreply.github.com> * rebase conflict * include pass and os in mirgration data * node network ranges * remove debugging logs * add gateways * use sent node * upgrade shell script * associate node to host during migration * add node to host.Nodes and publish peer update * save host outside loop * fix script name * simplify upgrade script * don't migrate relays * simplify upgrade script even more * guard against blank address or address6 * typos --------- Co-authored-by: Aceix <aceixsmartX@gmail.com> Co-authored-by: Abhishek K <32607604+abhishek9686@users.noreply.github.com> Co-authored-by: Farukh Khan <farukhkhan21@gmail.com> Co-authored-by: Gabriel de Souza Seibel <gabrielseibel1@gmail.com> Co-authored-by: bornav <51048565+bornav@users.noreply.github.com> Co-authored-by: Alex Feiszli <31018251+afeiszli@users.noreply.github.com> Co-authored-by: Christopher Blaha <crispspiceguitar@gmail.com> Co-authored-by: Abhishek Kondur <abhi281342@gmail.com>

* Add limited http handlers functionality to rest handler * Export ee.errValidation (ee.ErrValidation) * Export a fatal error handled by the hook manager * Export a new status variable for unlicensed server * Mark server as unlicensed when ee checks fail * Handle license validation failures with a (re)boot in a limited state * Revert "Export a fatal error handled by the hook manager" This reverts commit 069c219. * Revert "Export ee.errValidation (ee.ErrValidation)" This reverts commit 59dbab8. * Revert "Add limited http handlers functionality to rest handler" This reverts commit e2f1f28. * Revert "Handle license validation failures with a (re)boot in a limited state" This reverts commit 58cfbba. * Revert "Mark server as unlicensed when ee checks fail" This reverts commit 77c6dbd. * Handle license validation failures with a middleware * Forbid responses if unlicensed ee and not in status api * Remove unused func

* create gateways during migration * set version for testing * restruct migration * debug logging * enforce unique names for ext client names (#2476) * enforce unique names for ext client names * only check for unique id on creation * check for unique id if changed * prune(NET-483): remove defunct host.internetgateway field (#2487) * don't reference host on err (#2493) * deprecrate netclient install scripts (#2490) * Net 500: validate network parameter passed to node endpoints (#2480) * enforce unique names for ext client names * only check for unique id on creation * check for unique id if changed * validate network parameter passed to node endpoints --------- Co-authored-by: Abhishek K <32607604+abhishek9686@users.noreply.github.com> * NET-513 (#2492) nm-certs.sh now requests certificate for EE and CE edition domains accordingly. * [NET-404] Run in limited mode when ee checks fail (#2474) * Add limited http handlers functionality to rest handler * Export ee.errValidation (ee.ErrValidation) * Export a fatal error handled by the hook manager * Export a new status variable for unlicensed server * Mark server as unlicensed when ee checks fail * Handle license validation failures with a (re)boot in a limited state * Revert "Export a fatal error handled by the hook manager" This reverts commit 069c219. * Revert "Export ee.errValidation (ee.ErrValidation)" This reverts commit 59dbab8. * Revert "Add limited http handlers functionality to rest handler" This reverts commit e2f1f28. * Revert "Handle license validation failures with a (re)boot in a limited state" This reverts commit 58cfbba. * Revert "Mark server as unlicensed when ee checks fail" This reverts commit 77c6dbd. * Handle license validation failures with a middleware * Forbid responses if unlicensed ee and not in status api * Remove unused func * feat(NET-449): add sync feature to request a host pull from server (#2491) * fix(NET-486): change client name length validation (#2498) set limit to 5<=x<=32 * [NET-477] Pick AMB URL dynamically (#2489) * Introduce config for environment * Introduce func to get environment * Choose accounts api host from environment * Test the ee package on workflows * Use build tag ee for license_test.go * [Feature]: nm-quick script tackling arm TODO support (#2488) * domain flag for auto installs * use static servers with custom domain (#2421) * send delete peer update always * fix add/remove host api calls * keep mq updates in a single go func * move branch test logic to devops (#2443) * handle IOT OS * save server name to env (#2460) * ensure branch test servers available after test runs (#2467) * save server name to env * free server always; add PR to discord messages * use correct method to delete droplets (#2468) * quick fix for the launcher * removed exit when triggering not supported exit and removed the TODO comments related to this issue --------- Co-authored-by: Matthew R Kasun <mkasun@nusak.ca> Co-authored-by: Alex Feiszli <31018251+afeiszli@users.noreply.github.com> Co-authored-by: Christopher Blaha <crispspiceguitar@gmail.com> Co-authored-by: Abhishek Kondur <abhi281342@gmail.com> Co-authored-by: Abhishek K <32607604+abhishek9686@users.noreply.github.com> * rebase conflict * include pass and os in mirgration data * node network ranges * remove debugging logs * add gateways * use sent node * upgrade shell script * associate node to host during migration * add node to host.Nodes and publish peer update * save host outside loop * fix script name * simplify upgrade script * don't migrate relays * simplify upgrade script even more * guard against blank address or address6 * typos --------- Co-authored-by: Aceix <aceixsmartX@gmail.com> Co-authored-by: Abhishek K <32607604+abhishek9686@users.noreply.github.com> Co-authored-by: Farukh Khan <farukhkhan21@gmail.com> Co-authored-by: Gabriel de Souza Seibel <gabrielseibel1@gmail.com> Co-authored-by: bornav <51048565+bornav@users.noreply.github.com> Co-authored-by: Alex Feiszli <31018251+afeiszli@users.noreply.github.com> Co-authored-by: Christopher Blaha <crispspiceguitar@gmail.com> Co-authored-by: Abhishek Kondur <abhi281342@gmail.com>

* create gateways during migration * set version for testing * restruct migration * debug logging * enforce unique names for ext client names (#2476) * enforce unique names for ext client names * only check for unique id on creation * check for unique id if changed * prune(NET-483): remove defunct host.internetgateway field (#2487) * don't reference host on err (#2493) * deprecrate netclient install scripts (#2490) * Net 500: validate network parameter passed to node endpoints (#2480) * enforce unique names for ext client names * only check for unique id on creation * check for unique id if changed * validate network parameter passed to node endpoints --------- Co-authored-by: Abhishek K <32607604+abhishek9686@users.noreply.github.com> * NET-513 (#2492) nm-certs.sh now requests certificate for EE and CE edition domains accordingly. * [NET-404] Run in limited mode when ee checks fail (#2474) * Add limited http handlers functionality to rest handler * Export ee.errValidation (ee.ErrValidation) * Export a fatal error handled by the hook manager * Export a new status variable for unlicensed server * Mark server as unlicensed when ee checks fail * Handle license validation failures with a (re)boot in a limited state * Revert "Export a fatal error handled by the hook manager" This reverts commit 069c219. * Revert "Export ee.errValidation (ee.ErrValidation)" This reverts commit 59dbab8. * Revert "Add limited http handlers functionality to rest handler" This reverts commit e2f1f28. * Revert "Handle license validation failures with a (re)boot in a limited state" This reverts commit 58cfbba. * Revert "Mark server as unlicensed when ee checks fail" This reverts commit 77c6dbd. * Handle license validation failures with a middleware * Forbid responses if unlicensed ee and not in status api * Remove unused func * feat(NET-449): add sync feature to request a host pull from server (#2491) * fix(NET-486): change client name length validation (#2498) set limit to 5<=x<=32 * [NET-477] Pick AMB URL dynamically (#2489) * Introduce config for environment * Introduce func to get environment * Choose accounts api host from environment * Test the ee package on workflows * Use build tag ee for license_test.go * [Feature]: nm-quick script tackling arm TODO support (#2488) * domain flag for auto installs * use static servers with custom domain (#2421) * send delete peer update always * fix add/remove host api calls * keep mq updates in a single go func * move branch test logic to devops (#2443) * handle IOT OS * save server name to env (#2460) * ensure branch test servers available after test runs (#2467) * save server name to env * free server always; add PR to discord messages * use correct method to delete droplets (#2468) * quick fix for the launcher * removed exit when triggering not supported exit and removed the TODO comments related to this issue --------- Co-authored-by: Matthew R Kasun <mkasun@nusak.ca> Co-authored-by: Alex Feiszli <31018251+afeiszli@users.noreply.github.com> Co-authored-by: Christopher Blaha <crispspiceguitar@gmail.com> Co-authored-by: Abhishek Kondur <abhi281342@gmail.com> Co-authored-by: Abhishek K <32607604+abhishek9686@users.noreply.github.com> * rebase conflict * include pass and os in mirgration data * node network ranges * remove debugging logs * add gateways * use sent node * upgrade shell script * associate node to host during migration * add node to host.Nodes and publish peer update * save host outside loop * fix script name * simplify upgrade script * don't migrate relays * simplify upgrade script even more * guard against blank address or address6 * typos * fix convertsion of persistent keepalive * remove weird paste * another paste error --------- Co-authored-by: Aceix <aceixsmartX@gmail.com> Co-authored-by: Abhishek K <32607604+abhishek9686@users.noreply.github.com> Co-authored-by: Farukh Khan <farukhkhan21@gmail.com> Co-authored-by: Gabriel de Souza Seibel <gabrielseibel1@gmail.com> Co-authored-by: bornav <51048565+bornav@users.noreply.github.com> Co-authored-by: Alex Feiszli <31018251+afeiszli@users.noreply.github.com> Co-authored-by: Christopher Blaha <crispspiceguitar@gmail.com> Co-authored-by: Abhishek Kondur <abhi281342@gmail.com>

* create gateways during migration * set version for testing * restruct migration * debug logging * enforce unique names for ext client names (#2476) * enforce unique names for ext client names * only check for unique id on creation * check for unique id if changed * prune(NET-483): remove defunct host.internetgateway field (#2487) * don't reference host on err (#2493) * deprecrate netclient install scripts (#2490) * Net 500: validate network parameter passed to node endpoints (#2480) * enforce unique names for ext client names * only check for unique id on creation * check for unique id if changed * validate network parameter passed to node endpoints --------- Co-authored-by: Abhishek K <32607604+abhishek9686@users.noreply.github.com> * NET-513 (#2492) nm-certs.sh now requests certificate for EE and CE edition domains accordingly. * [NET-404] Run in limited mode when ee checks fail (#2474) * Add limited http handlers functionality to rest handler * Export ee.errValidation (ee.ErrValidation) * Export a fatal error handled by the hook manager * Export a new status variable for unlicensed server * Mark server as unlicensed when ee checks fail * Handle license validation failures with a (re)boot in a limited state * Revert "Export a fatal error handled by the hook manager" This reverts commit 069c219. * Revert "Export ee.errValidation (ee.ErrValidation)" This reverts commit 59dbab8. * Revert "Add limited http handlers functionality to rest handler" This reverts commit e2f1f28. * Revert "Handle license validation failures with a (re)boot in a limited state" This reverts commit 58cfbba. * Revert "Mark server as unlicensed when ee checks fail" This reverts commit 77c6dbd. * Handle license validation failures with a middleware * Forbid responses if unlicensed ee and not in status api * Remove unused func * feat(NET-449): add sync feature to request a host pull from server (#2491) * fix(NET-486): change client name length validation (#2498) set limit to 5<=x<=32 * [NET-477] Pick AMB URL dynamically (#2489) * Introduce config for environment * Introduce func to get environment * Choose accounts api host from environment * Test the ee package on workflows * Use build tag ee for license_test.go * [Feature]: nm-quick script tackling arm TODO support (#2488) * domain flag for auto installs * use static servers with custom domain (#2421) * send delete peer update always * fix add/remove host api calls * keep mq updates in a single go func * move branch test logic to devops (#2443) * handle IOT OS * save server name to env (#2460) * ensure branch test servers available after test runs (#2467) * save server name to env * free server always; add PR to discord messages * use correct method to delete droplets (#2468) * quick fix for the launcher * removed exit when triggering not supported exit and removed the TODO comments related to this issue --------- Co-authored-by: Matthew R Kasun <mkasun@nusak.ca> Co-authored-by: Alex Feiszli <31018251+afeiszli@users.noreply.github.com> Co-authored-by: Christopher Blaha <crispspiceguitar@gmail.com> Co-authored-by: Abhishek Kondur <abhi281342@gmail.com> Co-authored-by: Abhishek K <32607604+abhishek9686@users.noreply.github.com> * rebase conflict * include pass and os in mirgration data * node network ranges * remove debugging logs * add gateways * use sent node * upgrade shell script * associate node to host during migration * add node to host.Nodes and publish peer update * save host outside loop * fix script name * simplify upgrade script * don't migrate relays * simplify upgrade script even more * guard against blank address or address6 * typos * fix convertsion of persistent keepalive * remove weird paste * another paste error * fix command typo --------- Co-authored-by: Matthew R Kasun <mkasun@nusak.ca> Co-authored-by: Aceix <aceixsmartX@gmail.com> Co-authored-by: Farukh Khan <farukhkhan21@gmail.com> Co-authored-by: Gabriel de Souza Seibel <gabrielseibel1@gmail.com> Co-authored-by: bornav <51048565+bornav@users.noreply.github.com> Co-authored-by: Alex Feiszli <31018251+afeiszli@users.noreply.github.com> Co-authored-by: Christopher Blaha <crispspiceguitar@gmail.com>

* use NewHosts to init hostfile * Revert "Bump github.com/txn2/txeh from 1.4.0 to 1.5.3 (#2464)" (#2475) This reverts commit aafaa91. * NET-433: Only Set Routes for NAT enabled egress GW (#2469) * remove related fields and code * remover metrics collection from server code * fw update struct * add ext client flag to metrics data * simply nat types * rm proxy update from cli * remove ingress routes from firewall update * check if egress ranges are present * rm unused func * ignore network parameter passed to delete ingress endpoint (#2471) * fix(NET-388): fix to update node dns toggle (#2472) * use local port for metrics pinger (#2479) * v0.20.5 release notes (#2482) * v0.20.5 release notes * add a known issue * update develop to v0.20.6 (#2485) * enforce unique names for ext client names (#2476) * enforce unique names for ext client names * only check for unique id on creation * check for unique id if changed * prune(NET-483): remove defunct host.internetgateway field (#2487) * don't reference host on err (#2493) * deprecrate netclient install scripts (#2490) * Net 500: validate network parameter passed to node endpoints (#2480) * enforce unique names for ext client names * only check for unique id on creation * check for unique id if changed * validate network parameter passed to node endpoints --------- Co-authored-by: Abhishek K <32607604+abhishek9686@users.noreply.github.com> * NET-513 (#2492) nm-certs.sh now requests certificate for EE and CE edition domains accordingly. * [NET-404] Run in limited mode when ee checks fail (#2474) * Add limited http handlers functionality to rest handler * Export ee.errValidation (ee.ErrValidation) * Export a fatal error handled by the hook manager * Export a new status variable for unlicensed server * Mark server as unlicensed when ee checks fail * Handle license validation failures with a (re)boot in a limited state * Revert "Export a fatal error handled by the hook manager" This reverts commit 069c219. * Revert "Export ee.errValidation (ee.ErrValidation)" This reverts commit 59dbab8. * Revert "Add limited http handlers functionality to rest handler" This reverts commit e2f1f28. * Revert "Handle license validation failures with a (re)boot in a limited state" This reverts commit 58cfbba. * Revert "Mark server as unlicensed when ee checks fail" This reverts commit 77c6dbd. * Handle license validation failures with a middleware * Forbid responses if unlicensed ee and not in status api * Remove unused func * feat(NET-449): add sync feature to request a host pull from server (#2491) * fix(NET-486): change client name length validation (#2498) set limit to 5<=x<=32 * [NET-477] Pick AMB URL dynamically (#2489) * Introduce config for environment * Introduce func to get environment * Choose accounts api host from environment * Test the ee package on workflows * Use build tag ee for license_test.go * [Feature]: nm-quick script tackling arm TODO support (#2488) * domain flag for auto installs * use static servers with custom domain (#2421) * send delete peer update always * fix add/remove host api calls * keep mq updates in a single go func * move branch test logic to devops (#2443) * handle IOT OS * save server name to env (#2460) * ensure branch test servers available after test runs (#2467) * save server name to env * free server always; add PR to discord messages * use correct method to delete droplets (#2468) * quick fix for the launcher * removed exit when triggering not supported exit and removed the TODO comments related to this issue --------- Co-authored-by: Matthew R Kasun <mkasun@nusak.ca> Co-authored-by: Alex Feiszli <31018251+afeiszli@users.noreply.github.com> Co-authored-by: Christopher Blaha <crispspiceguitar@gmail.com> Co-authored-by: Abhishek Kondur <abhi281342@gmail.com> Co-authored-by: Abhishek K <32607604+abhishek9686@users.noreply.github.com> * Bump github.com/go-playground/validator/v10 from 10.14.1 to 10.15.0 (#2503) Bumps [github.com/go-playground/validator/v10](https://github.com/go-playground/validator) from 10.14.1 to 10.15.0. - [Release notes](https://github.com/go-playground/validator/releases) - [Commits](go-playground/validator@v10.14.1...v10.15.0) --- updated-dependencies: - dependency-name: github.com/go-playground/validator/v10 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump golang.org/x/oauth2 from 0.10.0 to 0.11.0 (#2502) Bumps [golang.org/x/oauth2](https://github.com/golang/oauth2) from 0.10.0 to 0.11.0. - [Commits](golang/oauth2@v0.10.0...v0.11.0) --- updated-dependencies: - dependency-name: golang.org/x/oauth2 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump alpine from 3.18.2 to 3.18.3 (#2500) Bumps alpine from 3.18.2 to 3.18.3. --- updated-dependencies: - dependency-name: alpine dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Net 509 515 (#2496) * NET-509 * External client config files with IPv6 endpoints now have the [] separating the address and port. * NET-515 * Increased network name max length to 32 * NET-509-515 * Updated unit test for network name max length check. * Updated extclient endpoint ip string manipulation to use sprintf * Added proper error message for network name length more than max allowed. * NET-515 small typo fix for error strings should not be capitalized * [NET-494 / ACC-322] New free tier limits (#2495) * Rename var * Rename consts and use iota * Use switch instead of repeated else if * Rename limits related vars * Introduce new free tier limits * Measure new limits and report on license validation * Separate usage and limits, have new ones * Don't check for hosts and clients limits, but for machines instead * Error on egress creation @ free tier w/ internet gateways * Remove clients and hosts limit from code * Rename var * Rename consts and use iota * Use switch instead of repeated else if * Rename limits related vars * Introduce new free tier limits * Measure new limits and report on license validation * Separate usage and limits, have new ones * Don't check for hosts and clients limits, but for machines instead * Error on egress creation @ free tier w/ internet gateways * Remove clients and hosts limit from code * NET-507 (#2506) * NET-507 * Fixed server restart changing the node expiration date to the defaults. * Removed expired nodes removal from zombie cleanup routine. * Added a new expired nodes deletion routine which removes expired nodes every hour. * NET-507 suggested changes * Possible fix for zombie nodes upon node deletion from the UI. * Suggested changes implemented for expired nodes deletion go routine. * NET-507 typo fix * typo fix for DeleteNode purge parameter * NET-517 (#2510) * Fixed emqx docker compose file syntax and added volumes for persistence. * Added helper comments for docker-compose.yml and netmaker.env files to enable emqx broker support. * migration (#2509) * create gateways during migration * set version for testing * restruct migration * debug logging * enforce unique names for ext client names (#2476) * enforce unique names for ext client names * only check for unique id on creation * check for unique id if changed * prune(NET-483): remove defunct host.internetgateway field (#2487) * don't reference host on err (#2493) * deprecrate netclient install scripts (#2490) * Net 500: validate network parameter passed to node endpoints (#2480) * enforce unique names for ext client names * only check for unique id on creation * check for unique id if changed * validate network parameter passed to node endpoints --------- Co-authored-by: Abhishek K <32607604+abhishek9686@users.noreply.github.com> * NET-513 (#2492) nm-certs.sh now requests certificate for EE and CE edition domains accordingly. * [NET-404] Run in limited mode when ee checks fail (#2474) * Add limited http handlers functionality to rest handler * Export ee.errValidation (ee.ErrValidation) * Export a fatal error handled by the hook manager * Export a new status variable for unlicensed server * Mark server as unlicensed when ee checks fail * Handle license validation failures with a (re)boot in a limited state * Revert "Export a fatal error handled by the hook manager" This reverts commit 069c219. * Revert "Export ee.errValidation (ee.ErrValidation)" This reverts commit 59dbab8. * Revert "Add limited http handlers functionality to rest handler" This reverts commit e2f1f28. * Revert "Handle license validation failures with a (re)boot in a limited state" This reverts commit 58cfbba. * Revert "Mark server as unlicensed when ee checks fail" This reverts commit 77c6dbd. * Handle license validation failures with a middleware * Forbid responses if unlicensed ee and not in status api * Remove unused func * feat(NET-449): add sync feature to request a host pull from server (#2491) * fix(NET-486): change client name length validation (#2498) set limit to 5<=x<=32 * [NET-477] Pick AMB URL dynamically (#2489) * Introduce config for environment * Introduce func to get environment * Choose accounts api host from environment * Test the ee package on workflows * Use build tag ee for license_test.go * [Feature]: nm-quick script tackling arm TODO support (#2488) * domain flag for auto installs * use static servers with custom domain (#2421) * send delete peer update always * fix add/remove host api calls * keep mq updates in a single go func * move branch test logic to devops (#2443) * handle IOT OS * save server name to env (#2460) * ensure branch test servers available after test runs (#2467) * save server name to env * free server always; add PR to discord messages * use correct method to delete droplets (#2468) * quick fix for the launcher * removed exit when triggering not supported exit and removed the TODO comments related to this issue --------- Co-authored-by: Matthew R Kasun <mkasun@nusak.ca> Co-authored-by: Alex Feiszli <31018251+afeiszli@users.noreply.github.com> Co-authored-by: Christopher Blaha <crispspiceguitar@gmail.com> Co-authored-by: Abhishek Kondur <abhi281342@gmail.com> Co-authored-by: Abhishek K <32607604+abhishek9686@users.noreply.github.com> * rebase conflict * include pass and os in mirgration data * node network ranges * remove debugging logs * add gateways * use sent node * upgrade shell script * associate node to host during migration * add node to host.Nodes and publish peer update * save host outside loop * fix script name * simplify upgrade script * don't migrate relays * simplify upgrade script even more * guard against blank address or address6 * typos --------- Co-authored-by: Aceix <aceixsmartX@gmail.com> Co-authored-by: Abhishek K <32607604+abhishek9686@users.noreply.github.com> Co-authored-by: Farukh Khan <farukhkhan21@gmail.com> Co-authored-by: Gabriel de Souza Seibel <gabrielseibel1@gmail.com> Co-authored-by: bornav <51048565+bornav@users.noreply.github.com> Co-authored-by: Alex Feiszli <31018251+afeiszli@users.noreply.github.com> Co-authored-by: Christopher Blaha <crispspiceguitar@gmail.com> Co-authored-by: Abhishek Kondur <abhi281342@gmail.com> * dns tests * go mod tidy * set dns dir when testing * troubleshoot test failure * test fail troubleshooting * use txeh.RenderHostFile to compare --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Abhishek K <32607604+abhishek9686@users.noreply.github.com> Co-authored-by: Aceix <aceixsmartX@gmail.com> Co-authored-by: Christopher Blaha <crispspiceguitar@gmail.com> Co-authored-by: Farukh Khan <farukhkhan21@gmail.com> Co-authored-by: Gabriel de Souza Seibel <gabrielseibel1@gmail.com> Co-authored-by: bornav <51048565+bornav@users.noreply.github.com> Co-authored-by: Alex Feiszli <31018251+afeiszli@users.noreply.github.com> Co-authored-by: Abhishek Kondur <abhi281342@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

gabrielseibel1 requested review from Aceix, theguy951357, afeiszli, abhishek9686, mattkasun and uGiFarukh July 28, 2023 12:18

gabrielseibel1 self-assigned this Jul 28, 2023

gabrielseibel1 force-pushed the net-404 branch from 986ab1c to 58cfbba Compare July 28, 2023 12:19

gabrielseibel1 added 12 commits July 31, 2023 15:59

Add limited http handlers functionality to rest handler

fb29dea

Export ee.errValidation (ee.ErrValidation)

89dacc0

Export a fatal error handled by the hook manager

3c6f6f9

Export a new status variable for unlicensed server

9e520b6

Mark server as unlicensed when ee checks fail

aee1e80

Handle license validation failures with a (re)boot in a limited state

a4febe0

Revert "Export a fatal error handled by the hook manager"

199dc06

This reverts commit 069c219.

Revert "Export ee.errValidation (ee.ErrValidation)"

2d18154

This reverts commit 59dbab8.

Revert "Add limited http handlers functionality to rest handler"

7973944

This reverts commit e2f1f28.

Revert "Handle license validation failures with a (re)boot in a limit…

1b736bc

…ed state" This reverts commit 58cfbba.

Revert "Mark server as unlicensed when ee checks fail"

2bef48d

This reverts commit 77c6dbd.

Handle license validation failures with a middleware

a7266c7

gabrielseibel1 force-pushed the net-404 branch from 58cfbba to a7266c7 Compare July 31, 2023 19:22

abhishek9686 requested changes Aug 1, 2023

View reviewed changes

ee/ee_controllers/middleware.go Show resolved Hide resolved

Forbid responses if unlicensed ee and not in status api

ec6f6db

gabrielseibel1 requested a review from abhishek9686 August 1, 2023 11:34

Aceix requested changes Aug 1, 2023

View reviewed changes

gabrielseibel1 added 2 commits August 1, 2023 13:56

Remove unused func

c04b5a9

Merge branch 'develop' into net-404

5ff7970

gabrielseibel1 requested a review from Aceix August 1, 2023 17:21

abhishek9686 approved these changes Aug 2, 2023

View reviewed changes

Aceix approved these changes Aug 2, 2023

View reviewed changes

theguy951357 approved these changes Aug 2, 2023

View reviewed changes

abhishek9686 merged commit 922e7db into develop Aug 3, 2023
15 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[NET-404] Run in limited mode when ee checks fail #2474

[NET-404] Run in limited mode when ee checks fail #2474

gabrielseibel1 commented Jul 28, 2023

abhishek9686 commented Jul 28, 2023

Aceix left a comment

abhishek9686 commented Aug 1, 2023

theguy951357 left a comment

[NET-404] Run in limited mode when ee checks fail #2474

[NET-404] Run in limited mode when ee checks fail #2474

Conversation

gabrielseibel1 commented Jul 28, 2023

Describe your changes

Provide testing steps

Checklist before requesting a review

abhishek9686 commented Jul 28, 2023

Aceix left a comment

Choose a reason for hiding this comment

abhishek9686 commented Aug 1, 2023

theguy951357 left a comment

Choose a reason for hiding this comment