Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NET-1565 and yml to json #3085

Closed
wants to merge 2 commits into from
Closed

NET-1565 and yml to json #3085

wants to merge 2 commits into from

Conversation

yabinma
Copy link
Collaborator

@yabinma yabinma commented Aug 29, 2024

Describe your changes

Provide Issue ticket number if applicable/not in title

Provide testing steps

Checklist before requesting a review

  • My changes affect only 10 files or less.
  • I have performed a self-review of my code and tested it.
  • If it is a new feature, I have added thorough tests, my code is <= 1450 lines.
  • If it is a bugfix, my code is <= 200 lines.
  • My functions are <= 80 lines.
  • I have had my code reviewed by a peer.
  • My unit tests pass locally.
  • Netmaker is awesome.

Aceix and others added 2 commits August 28, 2024 18:52
@Aceix
fix: update yml references to json for v0.25.0 (#3083)
19d7bb1
@yabinma @abhishek9686
NET-1565:fix extClient ip conflict issue (#3082)
bbca20e 
* fix extClient ip conflict issue

* Update users.go

---------

Co-authored-by: Abhishek K <abhishek@netmaker.io>
@yabinma
Copy link
Collaborator Author

yabinma commented Aug 29, 2024

close it and there will be merge in new PR

@yabinma yabinma closed this Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhishek9686 abhishek9686 Awaiting requested review from abhishek9686

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yabinma @Aceix