feat(core): markdown smart wrapInLine #492
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview is ready. |
makhnatkin
reviewed
Nov 22, 2024
| } else { | ||
| // Calculate indentation from the first line | ||
| const firstLine = state.doc.lineAt(range.from); | ||
| let indentation = ''; |
There was a problem hiding this comment.
Lets move code to getIndentation orcalculacteIndentation orparseIndentation`
and tests plz
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Third an last one in the series of PR's to markdown. This one is also fixing consistency between WYSIWYG and MARKDOWN modes. Now we can use buttons like checkbox and quote while maintaining integrity of markdown syntax in hardcore examples.
(tabs, lists, etc.)
Tabs.mov
PS: I will add test a little bit later