fix(CompositeBar/Item): support itemWrapper icon for highlighted node #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview is ready. |
DarkGenius
reviewed
Nov 14, 2023
| const iconNode = makeIconNode(iconEl); | ||
|
|
||
| if (bringForward) { | ||
| highlightedNode = iconNode; |
There was a problem hiding this comment.
The function makeNode has become a function with a side effect. I suggest leaving the variable highlightedNode definition in its place, but correcting the logic of its initialization (consider ItemWrapper).
Lunory
force-pushed
the
lunory/fix-highlighted-wrapper
branch
from
63cd3d2 to
573a05e
Compare
DarkGenius
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.